-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subs method for function field elements #38607
Conversation
Documentation preview for this PR (built with commit 6a34481; changes) is ready! 🎉 |
I'm not really sure what the rules/conventions are around using |
@DaveWitteMorris could I get a review? (Asking since you triaged the bug report.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are my suggestions; please let me know if you have any questions.
Co-authored-by: Travis Scrimshaw <[email protected]>
Co-authored-by: Travis Scrimshaw <[email protected]>
Thanks @tscrim! My only question is this one above:
|
Sorry, I forgot to answer that. Don’t worry about it; you do not need to add anything. It is for modularization that will be fixed by whomever knowns if something is necessary. |
Great! In that case is this ready to merge? I think the CI failures are unrelated. The tests pass on my machine at least. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I think this can be merged.
Fixes #38514.
📝 Checklist
⌛ Dependencies
None