Fix doctesting with Python 3.13 #39147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 15b14ca; changes) is ready! 🎉 |
user202729
reviewed
Dec 17, 2024
user202729
reviewed
Dec 17, 2024
tornaria
reviewed
Dec 20, 2024
| @@ -931,7 +936,7 @@ def summarize(self, verbose=None): | |||
| sage: from sage.doctest.control import DocTestDefaults; DD = DocTestDefaults() | |||
| sage: import doctest, sys, os | |||
| sage: DTR = SageDocTestRunner(SageOutputChecker(), verbose=False, sage_options=DD, optionflags=doctest.NORMALIZE_WHITESPACE|doctest.ELLIPSIS) | |||
| sage: DTR._name2ft['sage.doctest.forker'] = (1,120) | |||
| sage: DTR._stats['sage.doctest.forker'] = (1,120) | |||
There was a problem hiding this comment.
Suggested change
| sage: DTR._stats['sage.doctest.forker'] = (1,120) | |
| sage: DTR._stats['sage.doctest.forker'] = (1,120,0) |
It seems the difference between _name2ft and _stats is the former is pairs but the latter is triples.
There was a problem hiding this comment.
Yes, that's the point.
I think the doctest can be left as is because it's just mocking the result here… otherwise you'll need to do a version check.
I suggest adding an explanation why you're doing that here, so people coming across this in the future won't need to git blame the code.
tornaria
reviewed
Dec 22, 2024
Adapt to upstream changes in doctest [1]: - _name2ft was renamed to _stats - it now records the number of skipped tests [1] python/cpython@4f9b706
antonio-rojas
force-pushed
the
python-3.13-doctest
branch
from
cab66d8 to
15b14ca
Compare
user202729
approved these changes
Jan 5, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
sagemathgh-39147: Fix doctesting with Python 3.13 Adapt to upstream changes in doctest [1]: - _name2ft was renamed to _stats - it now records the number of skipped tests [1] python/cpython@4f9b706c6f5d4422a398146bfd0 11daedaef1851 URL: sagemath#39147 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, Gonzalo Tornaría, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 7, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
sagemathgh-39147: Fix doctesting with Python 3.13 Adapt to upstream changes in doctest [1]: - _name2ft was renamed to _stats - it now records the number of skipped tests [1] python/cpython@4f9b706c6f5d4422a398146bfd0 11daedaef1851 URL: sagemath#39147 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, Gonzalo Tornaría, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 9, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
sagemathgh-39147: Fix doctesting with Python 3.13 Adapt to upstream changes in doctest [1]: - _name2ft was renamed to _stats - it now records the number of skipped tests [1] python/cpython@4f9b706c6f5d4422a398146bfd0 11daedaef1851 URL: sagemath#39147 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, Gonzalo Tornaría, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 10, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
sagemathgh-39147: Fix doctesting with Python 3.13 Adapt to upstream changes in doctest [1]: - _name2ft was renamed to _stats - it now records the number of skipped tests [1] python/cpython@4f9b706c6f5d4422a398146bfd0 11daedaef1851 URL: sagemath#39147 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, Gonzalo Tornaría, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 12, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
sagemathgh-39147: Fix doctesting with Python 3.13 Adapt to upstream changes in doctest [1]: - _name2ft was renamed to _stats - it now records the number of skipped tests [1] python/cpython@4f9b706c6f5d4422a398146bfd0 11daedaef1851 URL: sagemath#39147 Reported by: Antonio Rojas Reviewer(s): Antonio Rojas, Gonzalo Tornaría, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 16, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 17, 2025
sagemathgh-39188: Declare Python 3.13 as supported in sagelib ### ⌛ Dependencies - sagemath#39145 - sagemath#39147 - sagemath#39182 - sagemath#39184 - sagemath#39185 - sagemath#39187 - sagemath#39201 URL: sagemath#39188 Reported by: Antonio Rojas Reviewer(s): Tobias Diez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to upstream changes in doctest [1]:
[1] python/cpython@4f9b706