-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Salvage work on gammoids #39155
Salvage work on gammoids #39155
Conversation
From archived `sagetrac-mirror` (branches `public/matroids/transversal_matroids-23536` and `u/zgershkoff/gammoids`).
Add unpickling method for `Gammoid`.
Documentation preview for this PR (built with commit 61f6748; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Math aside, the code looks good to me.
I believe the math was also double-checked by you and the original author.
sagemathgh-39155: Salvage work on gammoids Add matroid classes `Gammoid` and `TransversalMatroid`. Transversal matroids are also gammoids. From the archived [sagetrac- mirror](https://github.com/sagemath/sagetrac-mirror) repository (branches [public/matroids/transversal_matroids- 23536](https://github.com/sagemath/sagetrac- mirror/tree/public/matroids/transversal_matroids-23536) and [u/zgershkoff/gammoids](https://github.com/sagemath/sagetrac- mirror/tree/u/zgershkoff/gammoids)). Resolves sagemath#23536, resolves sagemath#23601, resolves sagemath#23628. URL: sagemath#39155 Reported by: gmou3 Reviewer(s): Kwankyu Lee
sagemathgh-39155: Salvage work on gammoids Add matroid classes `Gammoid` and `TransversalMatroid`. Transversal matroids are also gammoids. From the archived [sagetrac- mirror](https://github.com/sagemath/sagetrac-mirror) repository (branches [public/matroids/transversal_matroids- 23536](https://github.com/sagemath/sagetrac- mirror/tree/public/matroids/transversal_matroids-23536) and [u/zgershkoff/gammoids](https://github.com/sagemath/sagetrac- mirror/tree/u/zgershkoff/gammoids)). Resolves sagemath#23536, resolves sagemath#23601, resolves sagemath#23628. URL: sagemath#39155 Reported by: gmou3 Reviewer(s): Kwankyu Lee
As @collares pointed out in #38749, some of the tests fail with Python 3.12: https://github.com/sagemath/sage/actions/runs/12979684201/job/36195724175
Can you please have a look and fix these? Thanks! |
Thanks for the reporting. I figured out that there was a bug when choosing a new label for the newly created set. |
An error appears on some ``Python`` implementations because of a bug in ``transversal_extension``. The solution is to ensure that the label of `newset` is not `element`. Reported to me in sagemath#39155 (comment). URL: sagemath#39405 Reported by: gmou3 Reviewer(s): Frédéric Chapoton
An error appears on some ``Python`` implementations because of a bug in ``transversal_extension``. The solution is to ensure that the label of `newset` is not `element`. Reported to me in sagemath#39155 (comment). URL: sagemath#39405 Reported by: gmou3 Reviewer(s): Frédéric Chapoton
sagemathgh-39405: Resolve error in `transversal_matroid.pyx` An error appears on some ``Python`` implementations because of a bug in ``transversal_extension``. The solution is to ensure that the label of `newset` is not `element`. Reported to me in sagemath#39155 (comment). URL: sagemath#39405 Reported by: gmou3 Reviewer(s): Frédéric Chapoton
sagemathgh-39405: Resolve error in `transversal_matroid.pyx` An error appears on some ``Python`` implementations because of a bug in ``transversal_extension``. The solution is to ensure that the label of `newset` is not `element`. Reported to me in sagemath#39155 (comment). URL: sagemath#39405 Reported by: gmou3 Reviewer(s): Frédéric Chapoton
sagemathgh-39405: Resolve error in `transversal_matroid.pyx` An error appears on some ``Python`` implementations because of a bug in ``transversal_extension``. The solution is to ensure that the label of `newset` is not `element`. Reported to me in sagemath#39155 (comment). URL: sagemath#39405 Reported by: gmou3 Reviewer(s): Frédéric Chapoton
sagemathgh-39405: Resolve error in `transversal_matroid.pyx` An error appears on some ``Python`` implementations because of a bug in ``transversal_extension``. The solution is to ensure that the label of `newset` is not `element`. Reported to me in sagemath#39155 (comment). URL: sagemath#39405 Reported by: gmou3 Reviewer(s): Frédéric Chapoton
sagemathgh-39405: Resolve error in `transversal_matroid.pyx` An error appears on some ``Python`` implementations because of a bug in ``transversal_extension``. The solution is to ensure that the label of `newset` is not `element`. Reported to me in sagemath#39155 (comment). URL: sagemath#39405 Reported by: gmou3 Reviewer(s): Frédéric Chapoton
Add matroid classes
Gammoid
andTransversalMatroid
. Transversal matroids are also gammoids.From the archived sagetrac-mirror repository (branches public/matroids/transversal_matroids-23536 and u/zgershkoff/gammoids).
Resolves #23536, resolves #23601, resolves #23628.