New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix find_replacements with Python 3.13 #39185

Merged

vbraun merged 3 commits into sagemath:develop from antonio-rojas:python-3.13-eval

Jan 18, 2025

Contributor

antonio-rojas commented Dec 22, 2024 •

edited

Loading

After PEP 667 implementation [1] globals() changes within an exec call are not propagated outside the call

[1] python/cpython@b034f14

github-actions bot added the s: needs review label

github-actions bot commented Dec 22, 2024 •

edited

Loading

Documentation preview for this PR (built with commit cee808a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

antonio-rojas mentioned this pull request

Declare Python 3.13 as supported in sagelib #39188

Merged

Contributor

user202729 commented Dec 22, 2024

Instead of using globals() you can probably just use a temporary dict. Otherwise there's a risk of memory leak (the refcount isn't decreased when the function returns)

antonio-rojas added 3 commits

December 22, 2024 20:05


          Fix find_replacements with Python 3.13

481db2a

After PEP 667 implementation [1] locals() changes within an exec call are not propagated outside the call

[1] python/cpython@b034f14


          Simplify

b8cd5a6


          Use temporary dict as globals

cee808a

antonio-rojas force-pushed the python-3.13-eval branch from df521ad to cee808a Compare

December 22, 2024 19:09

user202729 approved these changes

View reviewed changes

tornaria added s: positive review and removed s: needs review labels

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39185: Fix find_replacements with Python 3.13

94e19ba

    
After PEP 667 implementation [1] `globals()` changes within an `exec`
call are not propagated outside the call

[1] python/cpython@b034f14a4b6e9197d3926046721
b8b4b4b4f5b3d
    
URL: sagemath#39185
Reported by: Antonio Rojas
Reviewer(s): user202729

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39188: Declare Python 3.13 as supported in sagelib

d22c28e

    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39185: Fix find_replacements with Python 3.13

c8b4dac

    
After PEP 667 implementation [1] `globals()` changes within an `exec`
call are not propagated outside the call

[1] python/cpython@b034f14a4b6e9197d3926046721
b8b4b4b4f5b3d
    
URL: sagemath#39185
Reported by: Antonio Rojas
Reviewer(s): user202729

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39188: Declare Python 3.13 as supported in sagelib

d85c58c

    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39185: Fix find_replacements with Python 3.13

f55231b

    
After PEP 667 implementation [1] `globals()` changes within an `exec`
call are not propagated outside the call

[1] python/cpython@b034f14a4b6e9197d3926046721
b8b4b4b4f5b3d
    
URL: sagemath#39185
Reported by: Antonio Rojas
Reviewer(s): user202729

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39188: Declare Python 3.13 as supported in sagelib

4c89e6e

    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39185: Fix find_replacements with Python 3.13

80b18c7

    
After PEP 667 implementation [1] `globals()` changes within an `exec`
call are not propagated outside the call

[1] python/cpython@b034f14a4b6e9197d3926046721
b8b4b4b4f5b3d
    
URL: sagemath#39185
Reported by: Antonio Rojas
Reviewer(s): user202729

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39188: Declare Python 3.13 as supported in sagelib

6e37abb

    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39185: Fix find_replacements with Python 3.13

1842bdc

    
After PEP 667 implementation [1] `globals()` changes within an `exec`
call are not propagated outside the call

[1] python/cpython@b034f14a4b6e9197d3926046721
b8b4b4b4f5b3d
    
URL: sagemath#39185
Reported by: Antonio Rojas
Reviewer(s): user202729

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39188: Declare Python 3.13 as supported in sagelib

2bdb354

    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-39188: Declare Python 3.13 as supported in sagelib

b5dbe52

    
### ⌛ Dependencies
- sagemath#39145
- sagemath#39147
- sagemath#39182
- sagemath#39184
- sagemath#39185
- sagemath#39187
- sagemath#39201
    
URL: sagemath#39188
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez

vbraun merged commit 57fa958 into sagemath:develop

23 checks passed

antonio-rojas deleted the python-3.13-eval branch

January 18, 2025 11:43

github-actions bot removed the s: positive review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet