Implement the atom (Demazure) basis (in type A) for the polynomial rings. #41026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
force-pushed
the
combinat/atom_basis
branch
from
516adc2 to
35d0dea
Compare
trevorkarn
reviewed
Oct 21, 2025
| EXAMPLES:: | ||
| sage: k = KeyPolynomials(QQ) | ||
| sage: k._monomial(k._indices([1, 3, 2, 0, 2])) |
There was a problem hiding this comment.
Should this be moved to tests, since underscore methods are generally hidden from users?
There was a problem hiding this comment.
There’s no point since the method is hidden from the doc anyways. (Separately, I also don’t think we should hide such tests/examples in general.)
trevorkarn
reviewed
Oct 21, 2025
| sage:a = AtomPolynomials(ZZ) | ||
| sage: X = SchubertPolynomialRing(ZZ) | ||
| sage: it = iter(Permutations()) | ||
| sage: for _ in range(50): |
There was a problem hiding this comment.
The bot is showing a failed example here
There was a problem hiding this comment.
The last push should fix it.
trevorkarn
suggested changes
Oct 21, 2025
trevorkarn
approved these changes
Oct 21, 2025
|
LGTM. |
|
Thank you. Although something is (still) going wrong with the docbuild according to the bot. |
|
Documentation preview for this PR (built with commit 5cc1c8d; changes) is ready! 🎉 |
|
Okay, now everything should work. |
|
LGTM. Thanks for the update. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 5, 2025
sagemathgh-41026: Implement the atom (Demazure) basis (in type A) for the polynomial rings. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This extends the framework for the key basis so that we can also perform computations in the atom basis. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41026 Reported by: Travis Scrimshaw Reviewer(s): Travis Scrimshaw, trevorkarn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends the framework for the key basis so that we can also perform computations in the atom basis.
📝 Checklist
⌛ Dependencies