Update linbox to 1.7.1 #41044
Open
Update linbox to 1.7.1 #41044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the linbox package from version 1.7.0+sage-2024-05-18 to 1.7.1, switching from a custom Sage release to the official upstream version.
- Updates package version and checksums for linbox 1.7.1
- Removes several patch files that are no longer needed in the new version
- Changes the upstream URL from a custom Sage repository to the official linbox-team repository
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build/pkgs/linbox/package-version.txt | Updates version from 1.7.0+sage-2024-05-18 to 1.7.1 |
| build/pkgs/linbox/checksums.ini | Updates checksums and upstream URL for the new version |
| build/pkgs/linbox/patches/43.patch | Removes patch file (no longer needed) |
| build/pkgs/linbox/patches/42.patch | Removes patch file (no longer needed) |
| build/pkgs/linbox/patches/41.patch | Removes patch file (no longer needed) |
| build/pkgs/linbox/patches/310-backport.patch | Removes patch file (no longer needed) |
| build/pkgs/linbox/patches/294.patch | Removes patch file (no longer needed) |
| build/pkgs/linbox/patches/292.patch | Removes patch file (no longer needed) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Documentation preview for this PR (built with commit f7a0e3c; changes) is ready! 🎉 |
|
The CI fails seems irrelevant. |
|
@jhpalmieri - could you check that this works on your very new Apple hard/software? |
|
I don't have particularly new hardware, but the software is up-to-date. This builds on two different OS X machines. If I see any doctest failures that might be related, I will let you know, but if I don't update this, assume it's fine. |
Thank you. |
dimpase
approved these changes
Oct 20, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 26, 2025
sagemathgh-41044: Update linbox to 1.7.1 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Because the new version of linbox contains all patches. So we can just delete the patches and bump the new version. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41044 Reported by: Chenxin Zhong Reviewer(s): Copilot, Dima Pasechnik
|
On ubuntu 12 I'm getting |
I have made a pr and report to the upstream. |
|
is this a 32-bit arch error? |
|
maybe we should get a 32-bit CI setup |
|
seems to work on 64-bit |
…:Integer to long This patch fixes compilation issues with clang/libc++ by ensuring coefficients are properly converted via the coefficient field, avoiding ambiguous implicit conversions when setting NTL polynomial coefficients. Related to: linbox-team/linbox#329
github-actions
bot
added
s: needs review
and removed
s: positive review
s: needs work
labels
The patch is applied. Can you test it? I do not have 32-bit arch device. @vbraun |
|
Thank you. @vbraun |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 1, 2025
sagemathgh-41044: Update linbox to 1.7.1 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Because the new version of linbox contains all patches. So we can just delete the patches and bump the new version. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41044 Reported by: Chenxin Zhong Reviewer(s): Copilot, Dima Pasechnik
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Nov 2, 2025
sagemathgh-41044: Update linbox to 1.7.1 <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Because the new version of linbox contains all patches. So we can just delete the patches and bump the new version. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41044 Reported by: Chenxin Zhong Reviewer(s): Copilot, Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the new version of linbox contains all patches. So we can just delete the patches and bump the new version.
📝 Checklist
⌛ Dependencies