Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hub: cleanup data of deleted projects #7667

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

hub: cleanup data of deleted projects #7667

wants to merge 15 commits into from

Conversation

haraldschilly
Copy link
Contributor

@haraldschilly haraldschilly commented Jul 5, 2024 •
edited
Loading

Description

  • on-prem related
  • updating pg + @types/pg (because I needed a function, and typing inconsistent)
  • generic and robust bulk delete operation
  • lot's of problems with actually running tests. I hope my changes fix this for good. Hard to test for me, because locally so many tests fail.
  • new destructive actions
    • calling db.delete_syncstring for all strings of deleted projects
    • for onprem only, cleaning up various tables, where rows reference a deleted project

Checklist:

  • Testing instructions are provided, if not obvious
  • Release instructions are provided, if not obvious

@williamstein
Copy link
Contributor

huge +1! It'll be a good foundation for doing this better in general.

@haraldschilly haraldschilly force-pushed the delete-project-data branch 2 times, most recently from 0646bf4 to 37d39b0 Compare July 10, 2024 15:24
@haraldschilly haraldschilly force-pushed the delete-project-data branch 3 times, most recently from c725c35 to ff5f370 Compare July 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR-work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haraldschilly @williamstein