-
Notifications
You must be signed in to change notification settings - Fork 221
Conat -- replacing NATS with socketio + sqlite3 + valkey + nodejs #8346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
williamstein
wants to merge
162
commits into
master
Choose a base branch
from
conat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10,715
−12,711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- did a bunch of benchmarks and tests, since I'm not going down the memory leak nightmare rabbit whole later!
- this is so frickin nice.
- no auth yet
- it was very easy and we might as well, as it suddenly provides a very, very powerful feature that we might find useful somewhere
… were massive work to write)
…g and as explained is a bad approach anyways (switch to using conat pub/sub!)
(since node 18 is already end of life and I do all dev with node 20 anyways) diff --git a/.github/workflows/make-and-test.yml b/.github/workflows/make-and-test.yml index a59eb60..88d31ea 100644 --- a/.github/workflows/make-and-test.yml +++ b/.github/workflows/make-and-test.yml @@ -65,7 +65,8 @@ jobs: matrix: # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ node-version: - - "18.17.1" + - "18" + - "20" pg-version: - "13.12" - "16"
…course - since it is a DOS vulnerability, and we don't need it anyways.
… new simple service method to conat client
- need to limit total memory usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.