Changed SAMBRO homepage 500 error #1494
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nursix
requested changes
Oct 23, 2018
| except: | ||
| current.log.error("Cannot find Layer for Map") | ||
| layer_id = None | ||
| Tkinter.messagebox.showinfo("Error", "Cannot find Layer for Map") |
There was a problem hiding this comment.
The message should be shown on the client-side, not on the server as normally there's no user there (hence the log message here). Besides, Tkinter is an optional module, and (for the same reason) not normally installed on the server.
The message can be shown either as HTML in place of the map (simply by putting it into the _map variable), or as response.error.
| try: | ||
| layer_id = layer.layer_id | ||
| skipMap = False |
There was a problem hiding this comment.
Naming convention: not pascalCase, but all_lower_case with underscore as word separator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by Nursix:
This happens due to missing map layer configurations - either because they have been deleted or not added to the database in the first place. This configuration error is logged, but no proper compensatory action is taken:
https://github.com/sahana/eden/blob/master/modules/templates/SAMBRO/controllers.py#L51
It would make sense to skip the entire map configuration (i.e. not call show_map at all) rather than just setting layer_id to None, and display a warning message to the user.