Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #577 - GUI: Choosing "Same file extension" results in "ERROR: Unknown option --match-with-extension." #578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #577 - GUI: Choosing "Same file extension" results in "ERROR: Unknown option --match-with-extension." #578

wants to merge 1 commit into from

Conversation

combs
Copy link
Contributor

@combs combs commented Jul 19, 2022

No description provided.

@combs combs mentioned this pull request Jul 19, 2022
Open
@cebtenzzre cebtenzzre linked an issue Aug 9, 2022 that may be closed by this pull request
GUI: Choosing "Same file extension" results in "ERROR: Unknown option --match-with-extension." #577
Open
@cebtenzzre cebtenzzre self-requested a review August 12, 2022 19:11
cebtenzzre
cebtenzzre suggested changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@cebtenzzre cebtenzzre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/rmlint.1.rst should be updated with the new option names, it still refers to match-with-extension/no-match-with-extension. And a shorter commit title that doesn't end with "..." would be preferred.

gui/shredder/runner.py Outdated Show resolved Hide resolved
@combs
Copy link
Contributor Author

combs commented Aug 14, 2022

Happy to update docs/rmlint.1.rst, done.

I do feel it may be outside the initial scope of this PR (I am not personally changing the option name here; I am just fixing a bug in the GUI introduced by 89dc901 .) But happy to squash two birds (?) with one stone.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cebtenzzre cebtenzzre cebtenzzre approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
topic-gui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GUI: Choosing "Same file extension" results in "ERROR: Unknown option --match-with-extension."
2 participants
@combs @cebtenzzre