Fix builds

sahinakkaya · Dec 6, 2024 · 801f39a · 801f39a
1 parent 367dafd
commit 801f39a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 2 deletions.
diff --git a/.github/workflows/clients.cd.yml b/.github/workflows/clients.cd.yml
@@ -39,6 +39,8 @@ jobs:
         with:
           context: client
           file: client/Dockerfile
+          build-args: |
+            REACT_APP_SOCKET_URL=https://blackjack-backend.sahinakkaya.dev
           push: true
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
diff --git a/client/Dockerfile b/client/Dockerfile
@@ -7,6 +7,9 @@ WORKDIR /app
 # Copy package.json and yarn.lock to the working directory
 COPY package.json yarn.lock ./
 
+
+ARG REACT_APP_SOCKET_URL
+ENV REACT_APP_SOCKET_URL=$REACT_APP_SOCKET_URL
 # Install dependencies using Yarn
 RUN yarn install --frozen-lockfile
 

diff --git a/client/src/server/socket.ts b/client/src/server/socket.ts
@@ -8,6 +8,8 @@ import { io } from 'socket.io-client';
 
 const socketWithoutTypes: Socket = io( process.env.REACT_APP_SOCKET_URL ?? 'http://localhost:8000');
 
+console.log('socket url', process.env.REACT_APP_SOCKET_URL);
+
 interface SocketEventsOn {
   [SocketOn.Connect]: () => void;
   [SocketOn.TableCreated]: (

diff --git a/infra/docker/docker-compose.yml b/infra/docker/docker-compose.yml
@@ -4,12 +4,12 @@ services:
     env_file:
       - .env.blackjack-frontend
     ports: 
-      - "8432:8000"
+      - "8432:3000"
 
 
   blackjack-backend:
     image: ghcr.io/sahinakkaya/blackjack-backend:main
     env_file:
       - .env.blackjack-backend
     ports: 
-      - "8433:3000"
+      - "8433:8000"