Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration and Cleanup: Move PICO_BOARD and ESP_PLATFORM to cmake #357

Merged
merged 5 commits into from
Aug 12, 2024

Conversation

Wolf3s
Copy link
Contributor

@Wolf3s Wolf3s commented Jul 11, 2024

* Move autotools build to CMake.

  • Support autotools functions in CMake.
  • Cleanup smb2man folder with CMakeLists.txt
  • Improve GSSAPI and libkrb5 detection.

@Wolf3s Wolf3s marked this pull request as draft July 11, 2024 20:16
@Wolf3s Wolf3s force-pushed the Cleanups branch 5 times, most recently from fff5ed9 to fcb284f Compare July 11, 2024 20:44
@Wolf3s Wolf3s marked this pull request as ready for review July 11, 2024 20:48
@Wolf3s Wolf3s force-pushed the Cleanups branch 6 times, most recently from c3da561 to bd5a880 Compare July 11, 2024 21:28
Bump to v4 in espressif and deprecate old link.
@Wolf3s Wolf3s marked this pull request as draft July 12, 2024 09:13
@Wolf3s Wolf3s force-pushed the Cleanups branch 3 times, most recently from 16fc1ba to fc07d24 Compare July 13, 2024 19:29
@Wolf3s Wolf3s changed the title Cleanup: Move PICO_BOARD and ESP_PLATFORM to a better place. Migration and Cleanup: Move PICO_BOARD and ESP_PLATFORM to Standard CMake plus migrate autotools to cmake. Jul 13, 2024
@Wolf3s Wolf3s marked this pull request as ready for review July 15, 2024 10:46
@Wolf3s Wolf3s force-pushed the Cleanups branch 3 times, most recently from 57ed60e to 76f7651 Compare July 16, 2024 10:12
@Wolf3s Wolf3s changed the title Migration and Cleanup: Move PICO_BOARD and ESP_PLATFORM to Standard CMake plus migrate autotools to cmake. Migration and Cleanup: Move PICO_BOARD and ESP_PLATFORM to make Jul 16, 2024
@Wolf3s Wolf3s changed the title Migration and Cleanup: Move PICO_BOARD and ESP_PLATFORM to make Migration and Cleanup: Move PICO_BOARD and ESP_PLATFORM to cmake Jul 17, 2024
Move autotools build to CMake.
Improve GSSAPI and libkrb5 detection.
@sahlberg
Copy link
Owner

sahlberg commented Aug 9, 2024

The other changes look fine but don't remove autotools.

@Wolf3s
Copy link
Contributor Author

Wolf3s commented Aug 9, 2024

The other changes look fine but don't remove autotools.

I will restore autotools build

@Wolf3s
Copy link
Contributor Author

Wolf3s commented Aug 9, 2024

@sahlberg

@sahlberg sahlberg merged commit aa1a223 into sahlberg:master Aug 12, 2024
15 of 16 checks passed
@sahlberg
Copy link
Owner

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants