Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github/codeql-action from 3.26.13 to 3.27.0 #175

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 28, 2024

Bumps github/codeql-action from 3.26.13 to 3.27.0.

Release notes

Sourced from github/codeql-action's releases.

v3.27.0

CodeQL Action Changelog

See the releases page for the relevant changes to the CodeQL CLI and language packs.

Note that the only difference between v2 and v3 of the CodeQL Action is the node version they support, with v3 running on node 20 while we continue to release v2 to support running on node 16. For example 3.22.11 was the first v3 release and is functionally identical to 2.22.11. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers.

3.27.0 - 22 Oct 2024

  • Bump the minimum CodeQL bundle version to 2.14.6. #2549
  • Fix an issue where the upload-sarif Action would fail with "upload-sarif post-action step failed: Input required and not supplied: token" when called in a composite Action that had a different set of inputs to the ones expected by the upload-sarif Action. #2557
  • Update default CodeQL bundle version to 2.19.2. #2552

See the full CHANGELOG.md for more information.

Commits
  • 6624720 Merge pull request #2561 from github/update-v3.27.0-b35b023d9
  • ce7c2b5 Update changelog for v3.27.0
  • b35b023 Merge pull request #2552 from github/update-bundle/codeql-bundle-v2.19.2
  • dafc762 Merge pull request #2560 from github/aeisenberg/fix-required-checks
  • 0d1eb88 Remove ESLint from required checks
  • 0a30541 Merge pull request #2558 from github/dependabot/npm_and_yarn/npm-6515e6e328
  • 2a6a6ad Update checked-in dependencies
  • 26c18c2 Bump the npm group with 3 updates
  • 7080a68 Merge branch 'main' into update-bundle/codeql-bundle-v2.19.2
  • 63eb7bb Merge pull request #2551 from github/cklin/diff-informed-queries-feature
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.26.13 to 3.27.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Commits](github/codeql-action@v3.26.13...v3.27.0)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 28, 2024
@saidsef
Copy link
Owner

saidsef commented Oct 29, 2024

/code pr

Copy link
Owner

@saidsef saidsef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖

Commit Review

The commit updates the github/codeql-action dependency from version 3.26.13 to 3.27.0 in the .github/workflows/charts.yml and .github/workflows/scorecard.yml files.

Enhancements and Issues

  1. Brevity in Commit Message:

    • The commit message could be more concise. For example:
    Bump github/codeql-action to 3.27.0
    
  2. Consistent Versioning in Scorecard Workflow:

    • In the .github/workflows/scorecard.yml file, the version of github/codeql-action is not updated correctly. It should match the version used in the charts workflow.
    - name: "Upload to code-scanning"
      uses: github/codeql-action/[email protected]
      with:
        sarif_file: results.sarif
  3. Minor Version Update Documentation:

    • It would be helpful to include a note about the minor version update in the commit message or in a separate documentation file.

Patched Files

  1. .github/workflows/charts.yml

    @@ -71,10 +71,10 @@ jobs:
        env:
          CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
      - name: Initialize CodeQL
      - uses: github/codeql-action/[email protected] # Updated version
        continue-on-error: true
      - name: Perform CodeQL Analysis
      - uses: github/codeql-action/[email protected] # Updated version
        continue-on-error: true
      - name: Run Trivy vulnerability scanner
        uses: aquasecurity/trivy-action@master
      @@ -84,7 +84,7 @@ jobs:
          format: 'sarif'
          output: 'trivy-results.sarif'
      - name: Upload Trivy scan results to GitHub Security tab
      - uses: github/codeql-action/[email protected] # Updated version
          with:
            sarif_file: 'trivy-results.sarif'
  2. .github/workflows/scorecard.yml

    @@ -31,6 +31,6 @@ jobs:
            path: results.sarif
            retention-days: 5
      - name: "Upload to code-scanning"
      - uses: github/codeql-action/[email protected] # Updated version
          with:
            sarif_file: results.sarif

Summary

The commit updates the github/codeql-action dependency correctly but could benefit from more concise commit messages and ensuring consistent versioning across workflows.

> llama-3.1-sonar-small-128k-chat [pr | 2]

@saidsef saidsef merged commit 8216585 into main Oct 29, 2024
3 checks passed
@saidsef saidsef deleted the dependabot-github_actions-github-codeql-action-3.27.0 branch October 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant