feat: [FC-18] leave group have silent and no silent #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huydosgtech
requested review from
honghoangsts,
loc-nguyenthien,
hoangSTS and
danhmaisgt
huydosgtech
force-pushed
the
feat/fc-18-leave-conversation
branch
from
f4634eb to
4084969
Compare
|
Video demo: Screen.Recording.2024-08-07.at.11.43.09.AM.movWhen leave, user list display:
|
danhmaisgt
force-pushed
the
feat/fc-18-leave-conversation
branch
from
4084969 to
0ba7ee2
Compare
huydosgtech
commented
Oct 15, 2024
src/services/firebase/firestore.ts
Outdated
| if ( | ||
| conversationData && | ||
| conversationData.unRead && | ||
| conversationData.unRead[this.userId] |
There was a problem hiding this comment.
I think only need check conversationData?.unRead?.[this.userId]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.