Skip to content

Commit

Permalink
PatchmanagerPage: Reorder pulley menu entries (#272)
Browse files Browse the repository at this point in the history
* PatchmanagerPage: Reorder pulley menu entries

… "Settings" shall be below "About" and easier to reach, plus "Deactivate all Patches" the hardest to reach (i.e., topmost)

* PatchManagerPage: Disable "Deactivate all Patches"

… pulley menu entry.
  • Loading branch information
Olf0 committed Feb 23, 2022
1 parent cda4162 commit d73c169
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions src/qml/PatchManagerPage.qml
Original file line number Diff line number Diff line change
Expand Up @@ -138,20 +138,25 @@ Page {
PullDownMenu {
busy: view.busy
enabled: !busy

/*
Disabled due to discussion at https://github.com/sailfishos-patches/patchmanager/pull/272#issuecomment-1047685536
MenuItem {
text: qsTranslate("", "Settings")
onClicked: pageStack.push(Qt.resolvedUrl("SettingsPage.qml"))
text: qsTranslate("", "Deactivate all Patches")
onClicked: menuRemorse.execute( text, function() { PatchManager.call(PatchManager.unapplyAllPatches()) } )
visible: PatchManager.loaded
}
*/

MenuItem {
text: qsTranslate("", "About Patchmanager")
onClicked: pageStack.push(Qt.resolvedUrl("AboutPage.qml"))
}

MenuItem {
text: qsTranslate("", "Deactivate all Patches")
onClicked: menuRemorse.execute( text, function() { PatchManager.call(PatchManager.unapplyAllPatches()) } )
visible: PatchManager.loaded
text: qsTranslate("", "Settings")
onClicked: pageStack.push(Qt.resolvedUrl("SettingsPage.qml"))
}

MenuItem {
Expand Down

0 comments on commit d73c169

Please sign in to comment.