-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ofono 1.30 #25
Open
piggz
wants to merge
127
commits into
sailfishos:master
Choose a base branch
from
sailfish-on-dontbeevil:branch-1.30
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
127 commits
Select commit
Hold shift + click to select a range
9441503
gprs: Always store RoamingAllowed as a boolean.
d99roric e0504cc
qmimodem: return all serial numbers
f21e2e1
AUTHORS: Mention Tom's contributions
denkenz ca1ce95
AUTHORS: Mention Alexander's contributions
denkenz d888ac4
AUTHORS: Mention Pau's contributions
denkenz 2f7ab43
network/ofono_netreg_status_notify: debug log the lac and ci
lynxis 8b24d80
network: debug log the network time on update
lynxis 011fc4d
gprs: netreg_status_changed: output the status as human readable string
lynxis 86e3717
qmi: netmon: fix crashs on get_rssi_cb when BER or RSSI are empty
lynxis 52f9861
xmm7modem: handling of IPv6 address for activated context
aborwank 3a38131
atmodem: Remove unneeded if statement
denkenz 3cbece5
ifxmodem: Remove unneeded if statement
denkenz efc4902
swmodem: Remove unneeded if statement
denkenz 124157d
hsomodem: Remove unneeded if statement
denkenz ee9970b
icera: Remove unneeded if statement
denkenz b70e511
huawei: Remove unneeded if statement
denkenz ac27238
telit: Remove unneeded if
denkenz a40f1f7
stemodem: Remove unneeded if
denkenz 692b25f
phoneseim: Remove unneeded if
denkenz c052366
mbmmodem: Remove unneeded if
denkenz 09f9fb7
log: Fix potential buffer overflow
denkenz 96fe543
qmimodem: Fix potential memory leak
denkenz fb22c17
sim: Dereference only after validating !NULL
denkenz 915dac4
handsfree: Dereference after validating !NULL
denkenz 19d1118
siri: Dereference after validating !NULL
denkenz 58d175e
gatchat: Remove unneeded if
denkenz 36823d8
stkutil: Call va_end on failure
denkenz 114d646
phonebook: fix invalid sprintf sequence
denkenz 20353f5
gprs: Remove unneeded if statement
denkenz 00d0755
gprs: Fix invalid string comparison
denkenz 0df509f
gprs: Remove unneeded if conditions
denkenz a722659
message-waiting: Fix logic error
denkenz 868d45f
sim-auth: Use memcpy instead of strncpy
denkenz 2546b4b
netmon: Fix logic error
denkenz 2cfe8bd
voicecall: Fix possible crash
denkenz fd9c099
sierra: Abort initialization on CFUN failure
denkenz c877350
atmodem: Fix a race if a context get deactivated while read
d99roric 9627883
udevng: add SIMCom SIM7600 modem support
herbrechtsmeier aa702ca
AUTHORS: Mention Stefan's contributions
denkenz f8d7709
build: Add check for explicit_bzero support
holtmann 5d22bc3
gatchat: Avoid string overflow warning in debug function
holtmann ef2a82c
radio-settings: adding UE dual mode operation property
aborwank f508507
radio-settings: handling of dual mode technology preference
aborwank ec4be0b
xmm7modem: handling of dual mode technology preference
aborwank 85cb899
xmm7modem: enabling simtoolkit in modem driver
aborwank 5a644a4
stemodem: Quiet warning about strncpy use
piggz 520c172
core: Quiet warning about strncpy use
piggz 285c6ee
main: Quiet ld errors with external ell
denkenz 32f878f
qmi: Fix style issues
denkenz f929c87
netmon: adding method to fetch neighbouring cell mesurement
aborwank 0cad44e
hfp_ag_bluez5: Remove unneeded forward declarations
denkenz 47ac8d3
atutil: Introduce at_util_open_device
denkenz 73cad86
wavecom: Use at_util_open_device
denkenz 9d8aeec
xmm7xxx: Use at_util_open_device
denkenz 553029c
zte: Use at_util_open_device
denkenz ca12d56
ublox: Use at_util_open_device
denkenz 5dc6ed0
telit: Use at_util_open_device
denkenz 1b203e5
speedup: Use at_util_open_device
denkenz 4c7f5a0
speedupcdma: Use at_util_open_device
denkenz d3dc982
sierra: Use at_util_open_device
denkenz f5a2ec3
samsung: Use at_util_open_device
denkenz 0a3bf91
quectel: Use at_util_open_device
denkenz af92d2d
novatel: Use at_util_open_device
denkenz cd71c68
nokia: Use at_util_open_device
denkenz cad8b7f
mbm: Use at_util_open_device
denkenz a0091fe
linktop: Use at_util_open_device
denkenz 8d7f24e
icera: Use at_util_open_device
denkenz ac3ba50
huawei: Use at_util_open_device
denkenz 4490cc2
hso: Use at_util_open_device
denkenz 852b56e
alcatel: Use at_util_open_device
denkenz e7e0187
qmimodem: change msg class none to store/notify
fa0b448
netmon: adding get function for neighbouring cell information
aborwank aa9b469
netmon: adding get functionality for neighbouring cell information
aborwank e0a6c79
xmm7modem: adding netmon changes for reporting neighbouring cell
aborwank 3538324
atmodem: fix to activate context with cid zero
aborwank 2355774
isimodem: gprs-context: properly null terminate cd->password
f38c79d
xmm7modem: disabling reporting of intermediate results for CGDATA
aborwank 770378b
mbim: Fix warning
denkenz 6c6e6d7
ubloxmodem: fix maybe-unitialized error
hundeboll aa6994a
gatresult: include glib header
hundeboll 813fb89
atutil: guard call to g_hash_table_destroy()
hundeboll bd69930
quectel: improve coding style
hundeboll da96fc3
quectel: fix initial channel/device configuration
hundeboll 79c1f16
atmodem: sms: add quectel m95 quirks
hundeboll a56411f
quectel: always print modem pointer in debug messages
hundeboll d623a1a
quectel: unwrap call to at_util_open_device()
hundeboll 99c973c
quectel: add basic support for serial connected modems
hundeboll cab967e
quectel: support gpio to power on/off the modem
hundeboll a6be848
quectel: configure flow control when enabled
hundeboll c706a2c
quectel: query device model to enable vendor quirks
hundeboll c4d61e8
quectel: initialize call, phonebook and sms when ready
hundeboll ce071ef
gatchat: Fix use of unterminated strings
denkenz 98781b1
gatresult: strip trailing spaces from unquoted strings
hundeboll ced704c
atmodem: rename OFONO_VENDOR_QUECTEL_M95
hundeboll 75c95ab
quectel: enable call volume settings
hundeboll 8266776
quectel: store model id in private data
hundeboll 686d669
quectel: add support for the Quectel MC60 modem
hundeboll 3d9e7f1
qmimodem: remember lac and cellid
christopheronco 3fa53e9
test: process-context-settings: use ip instead of ifconfig/route
hundeboll b0972e4
test: process-context-settings: print settings to stderr
hundeboll 46be146
atmodem: export generic netreg funcs
6ba5182
atmodem: export struct netreg
3ac48d1
ublox: determine gprs-context driver from network interface
1d78a9e
ublox: create only 1 gprs context
df14603
ublox: add voicecall support
b62a29c
ublox: add SMS support
d001f85
ublox: be explicit about lack of IPv6
8d91cdd
ublox: network-registration atom
d6e6b07
ublox: use custom netreg atom
ed8e9a9
ubloxmodem: Add model entries for LARA R2 series
ff434c2
udevng: detect LARA R2 series
66e59bc
atmodem: gprs-context: parse list-less CGDATA response
hundeboll a78f00e
quectel: pass vendor id to gprs and gprs-context
hundeboll 263436f
doc: add documentaion for Quectel hardware API
hundeboll 59b2a4a
quectel: add dbus hardware interface
hundeboll 3be8681
doc: document power-event signals for quectel Hardware API
hundeboll a8fb29e
quectel: implement dbus signals for modem power notifications
hundeboll 9a32087
atmodem: Check for auto activated contexts during init
d99roric bee0f26
gprs: Use -1 as netreg status during init.
d99roric a1436f8
gprs: Do not leak CID on failure to assign context
d99roric 6390bb8
isimodem: Fix size calculation for address array
holtmann 137e69d
gisi: Fix compiler warnings from -Waddress-of-packed-member
holtmann b9292d1
build: Add internal copy of linux/gpio.h for older systems
holtmann 17880d6
build: Add internal copy of linux/gsmmux.h for older systems
holtmann c0646c7
quectel: Add missing include for sys/socket.h
holtmann dd41759
build: Add missing drivers/atmodem/network-registration.h
holtmann e2d70e3
Release 1.30
holtmann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,158 @@ | ||
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ | ||
/* | ||
* <linux/gpio.h> - userspace ABI for the GPIO character devices | ||
* | ||
* Copyright (C) 2016 Linus Walleij | ||
* | ||
* This program is free software; you can redistribute it and/or modify it | ||
* under the terms of the GNU General Public License version 2 as published by | ||
* the Free Software Foundation. | ||
*/ | ||
#ifndef _GPIO_H_ | ||
#define _GPIO_H_ | ||
|
||
#include <linux/ioctl.h> | ||
#include <linux/types.h> | ||
|
||
/** | ||
* struct gpiochip_info - Information about a certain GPIO chip | ||
* @name: the Linux kernel name of this GPIO chip | ||
* @label: a functional name for this GPIO chip, such as a product | ||
* number, may be NULL | ||
* @lines: number of GPIO lines on this chip | ||
*/ | ||
struct gpiochip_info { | ||
char name[32]; | ||
char label[32]; | ||
__u32 lines; | ||
}; | ||
|
||
/* Informational flags */ | ||
#define GPIOLINE_FLAG_KERNEL (1UL << 0) /* Line used by the kernel */ | ||
#define GPIOLINE_FLAG_IS_OUT (1UL << 1) | ||
#define GPIOLINE_FLAG_ACTIVE_LOW (1UL << 2) | ||
#define GPIOLINE_FLAG_OPEN_DRAIN (1UL << 3) | ||
#define GPIOLINE_FLAG_OPEN_SOURCE (1UL << 4) | ||
|
||
/** | ||
* struct gpioline_info - Information about a certain GPIO line | ||
* @line_offset: the local offset on this GPIO device, fill this in when | ||
* requesting the line information from the kernel | ||
* @flags: various flags for this line | ||
* @name: the name of this GPIO line, such as the output pin of the line on the | ||
* chip, a rail or a pin header name on a board, as specified by the gpio | ||
* chip, may be NULL | ||
* @consumer: a functional name for the consumer of this GPIO line as set by | ||
* whatever is using it, will be NULL if there is no current user but may | ||
* also be NULL if the consumer doesn't set this up | ||
*/ | ||
struct gpioline_info { | ||
__u32 line_offset; | ||
__u32 flags; | ||
char name[32]; | ||
char consumer[32]; | ||
}; | ||
|
||
/* Maximum number of requested handles */ | ||
#define GPIOHANDLES_MAX 64 | ||
|
||
/* Linerequest flags */ | ||
#define GPIOHANDLE_REQUEST_INPUT (1UL << 0) | ||
#define GPIOHANDLE_REQUEST_OUTPUT (1UL << 1) | ||
#define GPIOHANDLE_REQUEST_ACTIVE_LOW (1UL << 2) | ||
#define GPIOHANDLE_REQUEST_OPEN_DRAIN (1UL << 3) | ||
#define GPIOHANDLE_REQUEST_OPEN_SOURCE (1UL << 4) | ||
|
||
/** | ||
* struct gpiohandle_request - Information about a GPIO handle request | ||
* @lineoffsets: an array of desired lines, specified by offset index for the | ||
* associated GPIO device | ||
* @flags: desired flags for the desired GPIO lines, such as | ||
* GPIOHANDLE_REQUEST_OUTPUT, GPIOHANDLE_REQUEST_ACTIVE_LOW etc, OR:ed | ||
* together. Note that even if multiple lines are requested, the same flags | ||
* must be applicable to all of them, if you want lines with individual | ||
* flags set, request them one by one. It is possible to select | ||
* a batch of input or output lines, but they must all have the same | ||
* characteristics, i.e. all inputs or all outputs, all active low etc | ||
* @default_values: if the GPIOHANDLE_REQUEST_OUTPUT is set for a requested | ||
* line, this specifies the default output value, should be 0 (low) or | ||
* 1 (high), anything else than 0 or 1 will be interpreted as 1 (high) | ||
* @consumer_label: a desired consumer label for the selected GPIO line(s) | ||
* such as "my-bitbanged-relay" | ||
* @lines: number of lines requested in this request, i.e. the number of | ||
* valid fields in the above arrays, set to 1 to request a single line | ||
* @fd: if successful this field will contain a valid anonymous file handle | ||
* after a GPIO_GET_LINEHANDLE_IOCTL operation, zero or negative value | ||
* means error | ||
*/ | ||
struct gpiohandle_request { | ||
__u32 lineoffsets[GPIOHANDLES_MAX]; | ||
__u32 flags; | ||
__u8 default_values[GPIOHANDLES_MAX]; | ||
char consumer_label[32]; | ||
__u32 lines; | ||
int fd; | ||
}; | ||
|
||
/** | ||
* struct gpiohandle_data - Information of values on a GPIO handle | ||
* @values: when getting the state of lines this contains the current | ||
* state of a line, when setting the state of lines these should contain | ||
* the desired target state | ||
*/ | ||
struct gpiohandle_data { | ||
__u8 values[GPIOHANDLES_MAX]; | ||
}; | ||
|
||
#define GPIOHANDLE_GET_LINE_VALUES_IOCTL _IOWR(0xB4, 0x08, struct gpiohandle_data) | ||
#define GPIOHANDLE_SET_LINE_VALUES_IOCTL _IOWR(0xB4, 0x09, struct gpiohandle_data) | ||
|
||
/* Eventrequest flags */ | ||
#define GPIOEVENT_REQUEST_RISING_EDGE (1UL << 0) | ||
#define GPIOEVENT_REQUEST_FALLING_EDGE (1UL << 1) | ||
#define GPIOEVENT_REQUEST_BOTH_EDGES ((1UL << 0) | (1UL << 1)) | ||
|
||
/** | ||
* struct gpioevent_request - Information about a GPIO event request | ||
* @lineoffset: the desired line to subscribe to events from, specified by | ||
* offset index for the associated GPIO device | ||
* @handleflags: desired handle flags for the desired GPIO line, such as | ||
* GPIOHANDLE_REQUEST_ACTIVE_LOW or GPIOHANDLE_REQUEST_OPEN_DRAIN | ||
* @eventflags: desired flags for the desired GPIO event line, such as | ||
* GPIOEVENT_REQUEST_RISING_EDGE or GPIOEVENT_REQUEST_FALLING_EDGE | ||
* @consumer_label: a desired consumer label for the selected GPIO line(s) | ||
* such as "my-listener" | ||
* @fd: if successful this field will contain a valid anonymous file handle | ||
* after a GPIO_GET_LINEEVENT_IOCTL operation, zero or negative value | ||
* means error | ||
*/ | ||
struct gpioevent_request { | ||
__u32 lineoffset; | ||
__u32 handleflags; | ||
__u32 eventflags; | ||
char consumer_label[32]; | ||
int fd; | ||
}; | ||
|
||
/** | ||
* GPIO event types | ||
*/ | ||
#define GPIOEVENT_EVENT_RISING_EDGE 0x01 | ||
#define GPIOEVENT_EVENT_FALLING_EDGE 0x02 | ||
|
||
/** | ||
* struct gpioevent_data - The actual event being pushed to userspace | ||
* @timestamp: best estimate of time of event occurrence, in nanoseconds | ||
* @id: event identifier | ||
*/ | ||
struct gpioevent_data { | ||
__u64 timestamp; | ||
__u32 id; | ||
}; | ||
|
||
#define GPIO_GET_CHIPINFO_IOCTL _IOR(0xB4, 0x01, struct gpiochip_info) | ||
#define GPIO_GET_LINEINFO_IOCTL _IOWR(0xB4, 0x02, struct gpioline_info) | ||
#define GPIO_GET_LINEHANDLE_IOCTL _IOWR(0xB4, 0x03, struct gpiohandle_request) | ||
#define GPIO_GET_LINEEVENT_IOCTL _IOWR(0xB4, 0x04, struct gpioevent_request) | ||
|
||
#endif /* _GPIO_H_ */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ | ||
#ifndef _LINUX_GSMMUX_H | ||
#define _LINUX_GSMMUX_H | ||
|
||
#include <linux/if.h> | ||
#include <linux/ioctl.h> | ||
#include <linux/types.h> | ||
|
||
struct gsm_config | ||
{ | ||
unsigned int adaption; | ||
unsigned int encapsulation; | ||
unsigned int initiator; | ||
unsigned int t1; | ||
unsigned int t2; | ||
unsigned int t3; | ||
unsigned int n2; | ||
unsigned int mru; | ||
unsigned int mtu; | ||
unsigned int k; | ||
unsigned int i; | ||
unsigned int unused[8]; /* Padding for expansion without | ||
breaking stuff */ | ||
}; | ||
|
||
#define GSMIOC_GETCONF _IOR('G', 0, struct gsm_config) | ||
#define GSMIOC_SETCONF _IOW('G', 1, struct gsm_config) | ||
|
||
struct gsm_netconfig { | ||
unsigned int adaption; /* Adaption to use in network mode */ | ||
unsigned short protocol;/* Protocol to use - only ETH_P_IP supported */ | ||
unsigned short unused2; | ||
char if_name[IFNAMSIZ]; /* interface name format string */ | ||
__u8 unused[28]; /* For future use */ | ||
}; | ||
|
||
#define GSMIOC_ENABLE_NET _IOW('G', 2, struct gsm_netconfig) | ||
#define GSMIOC_DISABLE_NET _IO('G', 3) | ||
|
||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -126,6 +126,7 @@ Lukasz Nowak <[email protected]> | |
Jonas Bonn <[email protected]> | ||
Matthijs Kooijman <[email protected]> | ||
Clayton Craft <[email protected]> | ||
Alexander Couzens <[email protected]> | ||
Joey Hewitt <[email protected]> | ||
Richard Röjfors <[email protected]> | ||
Philippe De Swert <[email protected]> | ||
|
@@ -139,5 +140,8 @@ Martin Hundebøll <[email protected]> | |
Julien Tournier <[email protected]> | ||
Nandini Rebello <[email protected]> | ||
Giacinto Cifelli <[email protected]> | ||
Pau Espin Pedrol <[email protected]> | ||
Khaled Romdhani <[email protected]> | ||
Pavel Machek <[email protected]> | ||
Tom Nguyen <[email protected]> | ||
Stefan Herbrechtsmeier <[email protected]> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
Hardware hierarchy | ||
================== | ||
|
||
Service org.ofono | ||
Interface org.ofono.quectel.Hardware | ||
Object path /{device0,device1,...} | ||
|
||
Methods array{string,variant} GetProperties | ||
|
||
Returns hardware properties for the modem object. See | ||
the properties section for available properties. | ||
|
||
Signals PowerDown(string reason) | ||
|
||
This signal is emitted on gracefull shutdowns initiated | ||
by the modem. | ||
|
||
Possible reasons: | ||
"VoltageLow" The supply voltage is too low | ||
"Normal" The PWRKEY pin was asserted | ||
"VoltageHigh" The supply voltage is too high | ||
|
||
PowerWarning(string reason) | ||
|
||
This signal is emitted when the modem detects its supply | ||
voltage is close to its supported limits. | ||
|
||
Possible reasons: | ||
"VoltageLow" The supply voltage is low | ||
"VoltageHigh" The supply voltage is high | ||
|
||
Properties int32 Voltage [readonly] | ||
|
||
Integer with the modem supply voltage in mV. | ||
|
||
int32 ChargeStatus [readonly,optional] | ||
|
||
Integer with one of either: | ||
|
||
0: Modem is not charging | ||
1: Modem is charging | ||
2: Charging is finished | ||
|
||
This property is available on UC15 | ||
|
||
int32 ChargeLevel [readonly,optional] | ||
|
||
Integer representing the battery charge level in | ||
percent (from 0 to 100). | ||
|
||
This property is available on UC15 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not going to work simply like that. "umts" is already interpreted by Sailfish OS as "umts,gsm", "lte" as LTE and anything below, and it's going to stay that way. We need a different syntax for "lte only" and "umts only" modes, to keep D-Bus interface backward compatible.
I've been thinking about it couple years ago: https://github.com/monich/ofono/commits/rats
👆It's not a finished work, I need to take another look at it before I can say if it's still a valid approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let me know if there is a commit (or several) from the PR that need to be dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@monich Have you had time to look into the branch yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there are good enough reasons otherwise, I'm thinking it could be better if we just switched the sailfish interpretation instead of indefinitely keeping a behavior difference to upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking backward compatibility (with 3rd party software which should survive upgrades) but since no one seems to care about it anymore then I can't think of any other reason🤷♂️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see some action on this, hopefully we can work to updating ofono soon