Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covid 19 Tracker Application #3

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Covid 19 Tracker Application #3

wants to merge 18 commits into from

Conversation

sainingo
Copy link
Owner

In this capstone project we were to choose an API endpoint to work with and I choose the covid 19 api.

I did the following:

  1. Selected an API that provides numeric data about a topic that I liked and then built the web app around it.
  2. The Home page contains a list of continents with some data about it
  3. When you click a specific continent the list of all countries in it is displayed alongside some data.

@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for global-19-tracker ready!

Name Link
🔨 Latest commit 1a90b29
🔍 Latest deploy log https://app.netlify.com/sites/global-19-tracker/deploys/628e1e56cbd3250008c4f912
😎 Deploy Preview https://deploy-preview-3--global-19-tracker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@GzimAsani GzimAsani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sainingo

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Good job so far 👏

Required Changes

  • _Check inline comments below ⏬ _

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding! clapclapclap

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/components/Home/Home.js Show resolved Hide resolved
src/App.js Outdated Show resolved Hide resolved
src/__tests__/App.test.js Show resolved Hide resolved
Copy link

@Mihndim2020 Mihndim2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STATUS: APPROVED!!! 🎉 🎉 🎉 🍾 🍾 🍾

Hi @sainingo,

Your project is complete! Great work on making the changes requested by the previous reviewer. There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉 🎉 🎉 🍾 🍾 🍾

Congratulations-Memes-FEATURED

Optional suggestions

Check the comments under the review.

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants