Support Winston as Custom Logger #33
Conversation
|
I added two commits, one for moving I tried to update the tests to use the instrumentation hook so that they align with the new instructions, but I couldn't find a good way as the tests invoke the Next logging and console logging directly instead of running the whole Next stack which will load the instrumentation hook. Let me know if you have any thoughts and I am happy to help update the code. And these are all of my current plans of changes, if there aren't anything new, I think you could bump up the version (5.x? since moving |
- Handle trace logging for winston properly - Add unit tests - Update README
Add Winston as a dev dependency so that it is installed during development and resolvable by eslint
- Make `pino` a peer dependencies and expand the version range, so that the users could pick their own version without having multiple copies in the bundle. - Update the README accordingly.
Update the instructions of using the library to use Next Instrumentation hook, which works for differerent cases including run from CLI, run through npm or standalone mode.
|
This is published now as |
Partially fix #29
Description
Fix the code and actually support winston as a custom logger
Testing
npm run testnpm run lint