clean up security advisor

sakaicontrib · Apr 18, 2024 · cefbb63 · cefbb63
1 parent bcaec88
commit cefbb63
Showing 1 changed file with 7 additions and 14 deletions.
diff --git a/...java/org/sakaiproject/certification/criteria/impl/gradebook/GradebookCriteriaFactory.java b/...java/org/sakaiproject/certification/criteria/impl/gradebook/GradebookCriteriaFactory.java
@@ -193,21 +193,14 @@ public boolean isCriterionMet(Criterion criterion) throws UnknownCriterionTypeEx
     protected Object doSecureGradebookAction(SecureGradebookActionCallback callback) throws Exception {
         final String contextId = contextId();
 
-        SecurityAdvisor yesMan = new SecurityAdvisor() {
-            public SecurityAdvice isAllowed(String userId, String function, String reference) {
-                String compTo;
-                if (contextId.startsWith("/site/")) {
-                    compTo = contextId;
-                } else {
-                    compTo = "/site/" + contextId;
-                }
+        SecurityAdvisor yesMan = (userId, function, reference) -> {
+            String compTo = contextId.startsWith("/site/") ? contextId : "/site/" + contextId;
 
-                if (reference.equals(compTo) && (PERM_VIEW_OWN_GRADES.equals(function) ||
-                                                 PERM_EDIT_ASSIGNMENTS.equals(function))) {
-                    return SecurityAdvice.ALLOWED;
-                } else {
-                    return SecurityAdvice.PASS;
-                }
+            if (reference.equals(compTo) && (PERM_VIEW_OWN_GRADES.equals(function) ||
+                                             PERM_EDIT_ASSIGNMENTS.equals(function))) {
+                return SecurityAdvisor.SecurityAdvice.ALLOWED;
+            } else {
+                return SecurityAdvisor.SecurityAdvice.PASS;
             }
         };