dockerize the app and add some install instructions #4
Conversation
|
Is this for demo'ing what exists or contributing to it? Only see 1 element in here so far so hard to conceptualize. It's a good idea; still assuming docker installed (tho easier than node / version issues but still) |
|
I like the idea, but it didn't work for me. Some permissions issue. If you could get this working so it just starts up storybook without any further intervention, that'd be cool. On the other hand, just using npm on your local box makes it easy enough to actually play with the stories, mod the code etc, and seeing as we'll have a sb build on nightly soon (hopefully), I'm not sure how useful this'll be. |
|
I think the target audience is like student devs who then don't need to fight node installation on potentially locked down machines vs allowing docker to invoke a container and then no special permissions needed. Reading into Michael's PR a bit but I know that's what we've discussed being possible in the past. Another name could be "allow windows users to actually use the system" ;) |
|
Fair point. Windows users. So, Mike, can you get this to actually just launch storybook from docker-compose up? |
|
was the permissions issue when trying to edit files @adrianfish or before you got to that point? |
|
It was before. Just as a heads up, I'm thinking that we could just do storybook in the main sakai repo, just add the storybook stuff to the webcomponents project and build it as usual. I don't see a ton of value in another repo, not at the minute anyway. |
I'm trying to keep my dev machine more containerized and added some docker stuff. I'm out of the loop on actual component development so didn't add any instructions past the setup stage but it seems like it should be fully compatible.
The beauty of this approach is that we shouldn't have to worry about new devs coming on board and what their machine looks like. If we have everyone go through docker we can control all those variables from within the dockerfile and docker-compose.