SAK-50560 Samigo fix matching feedback display to student when instru… (

#12943)
sakaiproject · Oct 4, 2024 · 2f8d957 · 2f8d957
1 parent fb2764f
commit 2f8d957
Showing 1 changed file with 4 additions and 17 deletions.
diff --git a/samigo/samigo-app/src/webapp/jsf/delivery/item/deliverMatching.jsp b/samigo/samigo-app/src/webapp/jsf/delivery/item/deliverMatching.jsp
@@ -38,25 +38,12 @@ should be included in file importing DeliveryMessages
   </t:dataList>
 
   <h:dataTable value="#{question.matchingArray}" var="matching">
-    <h:column rendered="#{delivery.feedback eq 'true' &&
-       delivery.feedbackComponent.showCorrectResponse && !delivery.noFeedback=='true'}">
-      <h:panelGroup id="image"
-        rendered="#{matching.isCorrect}"
-        styleClass="si si-check-lg" >
-      </h:panelGroup>
-      <h:panelGroup id="ximage"
-        rendered="#{!matching.isCorrect}"
-        styleClass="si si-remove feedBackCross" >
-      </h:panelGroup>
-      <h:graphicImage id="image2"
-        width="16" height="16"
-        alt="#{deliveryMessages.alt_incorrect}" url="/images/delivery/spacer.gif">
-      </h:graphicImage>
+    <h:column rendered="#{delivery.feedback eq true && delivery.feedbackComponent.showCorrectResponse eq true && delivery.noFeedback ne true}">
+      <h:panelGroup id="image" rendered="#{matching.isCorrect eq true}" styleClass="si si-check-lg" > </h:panelGroup>
+      <h:panelGroup id="ximage" rendered="#{matching.isCorrect eq false}" styleClass="si si-remove feedBackCross"> </h:panelGroup>
    </h:column>
    <h:column>
-     <t:selectOneMenu value="#{matching.response}" escape="false"
-      disabled="#{delivery.actionString=='reviewAssessment'
-               || delivery.actionString=='gradeAssessment'}">
+     <t:selectOneMenu value="#{matching.response}" escape="false" disabled="#{delivery.actionString=='reviewAssessment' || delivery.actionString=='gradeAssessment'}">
        <f:selectItems value="#{matching.choices}" />
      </t:selectOneMenu>
    </h:column>