-
-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAK-49082 DateManager improvements to additional nullable date support #11748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mylescarey2019
force-pushed
the
SAK-49082
branch
9 times, most recently
from
July 7, 2023 21:38
1ac5d62
to
99e6707
Compare
…button, fixes for SAK-46023, SAK-46212, SAK-48788, SAK-48789
ern
changed the title
SAK-49082: DateManager: Additional nullable date support, clear date button, fixes for SAK-46023, SAK-46212, SAK-48788, SAK-48789
SAK-49082 DateManager improvements to additional nullable date support
Jul 11, 2023
@mylescarey2019 Thank you for the PR In the future you should only mention the JIRA that this PR is for, you can mention any other related JIRA issues in the JIRA ticket. |
ern
reviewed
Jul 14, 2023
...nage/datemanager/impl/src/java/org/sakaiproject/datemanager/impl/DateManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jul 14, 2023
...nage/datemanager/impl/src/java/org/sakaiproject/datemanager/impl/DateManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jul 14, 2023
...nage/datemanager/impl/src/java/org/sakaiproject/datemanager/impl/DateManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jul 14, 2023
...nage/datemanager/impl/src/java/org/sakaiproject/datemanager/impl/DateManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
ern
reviewed
Jul 14, 2023
...nage/datemanager/impl/src/java/org/sakaiproject/datemanager/impl/DateManagerServiceImpl.java
Outdated
Show resolved
Hide resolved
ern
approved these changes
Jul 14, 2023
ern
pushed a commit
that referenced
this pull request
Sep 14, 2023
#11748) Co-authored-by: Earle Nietzel <[email protected]> (cherry picked from commit 28f5900)
ern
pushed a commit
that referenced
this pull request
Oct 27, 2023
#11748) Co-authored-by: Earle Nietzel <[email protected]> (cherry picked from commit 28f5900) Conflicts: site-manage/datemanager/tool/src/main/resources/static/js/initDatePicker.js site-manage/datemanager/tool/src/main/webapp/WEB-INF/templates/tool_fragment.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds UX features to Date Manager and fixes several open issues.
Fixed are the following:
From the re-opened SAK-46023 - Date Manager > Nullable fields for some activities needs to be allowed
Also fixed:
UX Features added to Date Manager: