Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAK-49082 DateManager improvements to additional nullable date support #11748

Merged
merged 6 commits into from
Aug 9, 2023

Conversation

mylescarey2019
Copy link
Contributor

This pull request adds UX features to Date Manager and fixes several open issues.
Fixed are the following:
From the re-opened SAK-46023 - Date Manager > Nullable fields for some activities needs to be allowed

  • Tests & Quizzes hide feedback date - No error, but no change in the settings. When you reload date manager, these dates re-appear
  • Announcements start/end dates - “Uncaught Error” in Date Manager when trying to save after clearing out dates
  • Lessons hide until date- “Uncaught Error” in Date Manager when trying to save after clearing out dates

Also fixed:

UX Features added to Date Manager:

  • Ability to clear any date - required date fields subject to validation upon Save
  • Assessible Clear date button
  • Date input field value now shows in title element (helpful for Accessibility and when dates fields compressed due to narrow screen widths (tablets, etc.)

image
image

@mylescarey2019 mylescarey2019 force-pushed the SAK-49082 branch 9 times, most recently from 1ac5d62 to 99e6707 Compare July 7, 2023 21:38
…button, fixes for SAK-46023, SAK-46212, SAK-48788, SAK-48789
@ern ern changed the title SAK-49082: DateManager: Additional nullable date support, clear date button, fixes for SAK-46023, SAK-46212, SAK-48788, SAK-48789 SAK-49082 DateManager improvements to additional nullable date support Jul 11, 2023
@ern
Copy link
Contributor

ern commented Jul 11, 2023

@mylescarey2019 Thank you for the PR

In the future you should only mention the JIRA that this PR is for, you can mention any other related JIRA issues in the JIRA ticket.

@ern ern merged commit 28f5900 into sakaiproject:master Aug 9, 2023
3 checks passed
ern pushed a commit that referenced this pull request Sep 14, 2023
ern pushed a commit that referenced this pull request Oct 27, 2023
#11748)

Co-authored-by: Earle Nietzel <[email protected]>
(cherry picked from commit 28f5900)

 Conflicts:
	site-manage/datemanager/tool/src/main/resources/static/js/initDatePicker.js
	site-manage/datemanager/tool/src/main/webapp/WEB-INF/templates/tool_fragment.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants