SAK-50348 Microsoft Integration: Visual and logical improvements #12781
Conversation
![accesslint[bot]](https://avatars.githubusercontent.com/in/1502?s=60&v=4){kind=small}
| <div class="row form-group"> | ||
| <div class="col-sm-5 text-end text-bold" th:text="#{sync_start_date}"></div> | ||
| <input type="date" id="syncDateFrom" th:value="${syncDateFrom}" th:aria-label="#{index.start_date}" /> | ||
| <div class="col-sm-4"> | ||
| <input type="date" id="syncDateFrom" th:value="${syncDateFrom}" th:aria-label="#{index.start_date}" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </div> | ||
| <div class="row form-group"> | ||
| <div class="col-sm-5 text-end text-bold" th:text="#{sync_end_date}"></div> | ||
| <input type="date" id="syncDateTo" th:value="${syncDateTo}" th:aria-label="#{index.end_date}" /> | ||
| <div class="col-sm-4"> | ||
| <input type="date" id="syncDateTo" th:value="${syncDateTo}" th:aria-label="#{index.end_date}" /> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="row table-space table-row"> | ||
|
|
||
| <div class="col-sm-5"> | ||
| <select name="new_group" id="selectedGroupId"> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </div> | ||
|
|
||
| <div class="col-sm-5"> | ||
| <select name="new_channel" id="selectedChannelId"> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </div> | ||
|
|
||
| <div class="col-sm-2 text-center"> | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" role="button" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
| if(payload.getSiteIdList() == null || payload.getSiteIdList().size() == 0 || payload.getSyncDateFrom() == null || payload.getSyncDateTo() == null) { | ||
| Model model) throws Exception { | ||
|
|
||
| if (payload.getSiteIdList() == null || payload.getSiteIdList().isEmpty() || |
There was a problem hiding this comment.
CollectionUtils.isEmpty(payload.getSiteIdList())
| try { | ||
| handleExistingTeamBinding(autoConfigSessionBean, site, (SiteSynchronization) o, syncDateFrom, syncDateTo, credentials); | ||
| } catch (Exception e) { | ||
| autoConfigSessionBean.addError(siteId, site.getTitle(), e.getMessage()); |
There was a problem hiding this comment.
Should we here put a log.error too?
| } | ||
|
|
||
| if (o instanceof String) { | ||
| autoConfigSessionBean.addStatus(1, site.getTitle()); |
There was a problem hiding this comment.
Maybe the status: 0, 1, 2, 3, etc should be defined as constants. But is ok
| private ConcurrentHashMap<String, Object> newGroupLock = new ConcurrentHashMap<>(); | ||
|
|
||
| //private static final int MAX_CHANNELS = 3; |
mollerentornos
force-pushed
the
master_sakai
branch
from
08dae0d to
a238565
Compare
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
|
PR updated |
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
mollerentornos
force-pushed
the
master_sakai
branch
from
ffd24f1 to
a238565
Compare
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
mollerentornos
force-pushed
the
master_sakai
branch
from
a238565 to
0b1d8b5
Compare
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" th:aria-label="#{error.user_synchronization}" role="button" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
...t-integration/admin-tool/src/main/webapp/WEB-INF/templates/fragments/synchronizationRow.html
Outdated
Show resolved
Hide resolved
mollerentornos
force-pushed
the
master_sakai
branch
from
0f29149 to
63f79ef
Compare
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
...t-integration/admin-tool/src/main/webapp/WEB-INF/templates/fragments/synchronizationRow.html
Outdated
Show resolved
Hide resolved
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'" th:aria-label="#{group.id(${grouprow.groupId})}"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" th:aria-label="#{error.user_synchronization}" role="button" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
mollerentornos
force-pushed
the
master_sakai
branch
from
2c89d2a to
b305229
Compare
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'" th:aria-label="#{group.id(${grouprow.groupId})}"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" th:aria-label="#{error.user_synchronization}" role="button" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
mollerentornos
force-pushed
the
master_sakai
branch
from
b305229 to
ce00aa7
Compare
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
...t-integration/admin-tool/src/main/webapp/WEB-INF/templates/fragments/synchronizationRow.html
Outdated
Show resolved
Hide resolved
mollerentornos
force-pushed
the
master_sakai
branch
from
ce00aa7 to
3047d33
Compare
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
...t-integration/admin-tool/src/main/webapp/WEB-INF/templates/fragments/synchronizationRow.html
Outdated
Show resolved
Hide resolved
mollerentornos
force-pushed
the
master_sakai
branch
from
3047d33 to
53c1aa4
Compare
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'" th:aria-label="#{group.id(${grouprow.groupId})}"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" th:aria-label="#{error.user_synchronization}" role="button" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
mollerentornos
force-pushed
the
master_sakai
branch
from
53c1aa4 to
94a6f49
Compare
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'" th:aria-label="#{group.id(${grouprow.groupId})}"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" th:aria-label="#{error.user_synchronization}" role="button" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
mollerentornos
force-pushed
the
master_sakai
branch
from
94a6f49 to
7c44f56
Compare
| <div class="col-sm-5" th:text="${groupsMap[entry.groupId]?.title} ?: '???'"></div> | ||
| <div class="col-sm-5" th:text="${channelsMap[entry.channelId]?.name ?: '???'}"></div> | ||
| <div th:if="${entry.channelId != ''}" class="col-sm-2 text-center" > | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'" th:aria-label="#{group.id(${grouprow.groupId})}"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" th:aria-label="#{error.user_synchronization}" role="button" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
bgarciaentornos
force-pushed
the
master_sakai
branch
from
7c44f56 to
aedac59
Compare
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
...t-integration/admin-tool/src/main/webapp/WEB-INF/templates/fragments/synchronizationRow.html
Outdated
Show resolved
Hide resolved
...egration/impl/src/main/java/org/sakaiproject/microsoft/impl/jobs/RunSynchronizationsJob.java
Outdated
Show resolved
Hide resolved
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Outdated
Show resolved
Hide resolved
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Outdated
Show resolved
Hide resolved
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Outdated
Show resolved
Hide resolved
...tegration/impl/src/main/java/org/sakaiproject/microsoft/impl/MicrosoftCommonServiceImpl.java
Outdated
Show resolved
Hide resolved
mollerentornos
force-pushed
the
master_sakai
branch
from
aedac59 to
6ba9272
Compare
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
...osoft-integration/admin-tool/src/main/webapp/WEB-INF/templates/editGroupSynchronization.html
Show resolved
Hide resolved
...t-integration/admin-tool/src/main/webapp/WEB-INF/templates/fragments/synchronizationRow.html
Show resolved
Hide resolved
|
@jesusmmp PR updated with requested changes |
mollerentornos
force-pushed
the
master_sakai
branch
from
6ba9272 to
8dd5868
Compare
| </div> | ||
| </div> | ||
| <div id="row-container" class="row-list"> | ||
| <div class="row table-space table-row"> | ||
| <div class="col-sm-5"> | ||
| <select name="new_group" id="selectedGroupId" th:aria-label="#{new_group}"> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </div> | ||
|
|
||
| <div class="col-sm-5"> | ||
| <select name="new_channel" id="selectedChannelId" th:aria-label="#{new_channel}"> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </div> | ||
|
|
||
| <div class="col-sm-2 text-center"> | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'" th:aria-label="#{group.id(${grouprow.groupId})}"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" role="button" th:aria-label="#{error.user_synchronization}" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
mollerentornos
force-pushed
the
master_sakai
branch
from
8dd5868 to
9f93d85
Compare
| </div> | ||
| </div> | ||
| <div id="row-container" class="row-list"> | ||
| <div class="row table-space table-row"> | ||
| <div class="col-sm-5"> | ||
| <select name="new_group" id="selectedGroupId" th:aria-label="#{new_group}"> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </div> | ||
|
|
||
| <div class="col-sm-5"> | ||
| <select name="new_channel" id="selectedChannelId" th:aria-label="#{new_channel}"> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| </div> | ||
|
|
||
| <div class="col-sm-2 text-center"> | ||
| <i role="button" |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
| <div class="col-lg-4" th:title="#{group.id(${grouprow.groupId})}" style="display: flex;justify-content: center; gap: 3px;"> | ||
| <span th:text="${groupsMap[grouprow.groupId]?.title} ?: '???'" th:aria-label="#{group.id(${grouprow.groupId})}"></span> | ||
| <div th:if="${T(org.sakaiproject.microsoft.api.data.SynchronizationStatus).ERROR == grouprow.status}" style="position: relative;"> | ||
| <i class="fa fa-info" style="color: red;" role="button" th:aria-label="#{error.user_synchronization}" th:onclick="toggleErrorsDropdown('dropdown-' +[[${grouprow.groupId}]])"></i> |
There was a problem hiding this comment.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
Jira: https://sakaiproject.atlassian.net/browse/SAK-50348
This feature introduces several essential modifications to provide users with more insight into the status of Microsoft integration and to manage bindings with an improved UI/UX. Additionally, it includes changes to the logical structure by adding batch requests to enhance performance.
This development has been sponsored by Universitat de Lleida (UdL)