SAK-50323 announcementswc Allow super users to view announcements #12880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ottenhoff
reviewed
Sep 11, 2024
| @@ -1271,15 +1272,20 @@ private List<String> getExcludedSitesFromTabs() { | |||
| return l; | |||
| } | |||
|
|
|||
| public Filter getMaxAgeInDaysFilter(int maxAgeInDays) { | |||
|
|
|||
| ViewableFilter viewableFilter = new ViewableFilter(null, null, Integer.MAX_VALUE, this); | |||
There was a problem hiding this comment.
this is a lot of announcements! What's a practical value? 1000?
There was a problem hiding this comment.
Fine by me. I was just going off what was there already. Which I probably put in in the first place :)
There was a problem hiding this comment.
It would be a thousand for each site though ..
There was a problem hiding this comment.
@ottenhoff How's that look now?
ottenhoff
approved these changes
Sep 11, 2024
|
@ottenhoff Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SAK-50323