SAK-50556 Global update dependencies for Sakai 25 #12924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LTI stuff LGTM |
ottenhoff
commented
Sep 27, 2024
| @@ -31,9 +31,9 @@ public void testInstantParse() throws Exception { | |||
| i = InstantUtil.parseGMTFormats(txt); | |||
| assertEquals(i.toString(), "2008-04-09T23:55:38Z"); | |||
|
|
|||
| txt = "Fri Feb 15 14:45:01 2013"; | |||
There was a problem hiding this comment.
this is a very strange date @csev .... where did you find it?
ern
reviewed
Sep 28, 2024
master/pom.xml
Outdated
Comment on lines
731
to
736
| <dependency> | ||
| <groupId>commons-collections</groupId> | ||
| <artifactId>commons-collections</artifactId> | ||
| <version>3.2.2</version> | ||
| <scope>provided</scope> | ||
| </dependency> |
There was a problem hiding this comment.
see SAK-49906, this is transitively needed
There was a problem hiding this comment.
i think i understand.... you'd rather just declare it centrally instead of having old tool dependencies like velocity and tomahawk bring it in transitively
ottenhoff
changed the title
ern
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.