SAK-50554 Site Import Fails to Import Some Embedded Images #12937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusmmp
approved these changes
Oct 1, 2024
ottenhoff
reviewed
Oct 1, 2024
kernel/kernel-impl/src/main/java/org/sakaiproject/util/impl/LinkMigrationHelperImpl.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the import process, in the migration of links, it is checked whether the links are shortened, and then they are expanded. To do this, it checks if the link includes the string "http://bit.ly/ " or "/x/".
This check fails when we encounter an image inserted with its base64 encoding, a format in which images from the clipboard were pasted in previous versions of Sakai.
<img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA... (rest of the base64 encoding)">This string is very long and is highly likely to include "/x/". As a result, a large number of images from a variety of tools are lost.
https://sakaiproject.atlassian.net/browse/SAK-50554