Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix moc files not using PCH when cotired. Added the possibility to specify the path to stdafx.cpp to cotire instead of passing it as first argument to add_library and add_executable. #147

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fkorsa
Copy link

@fkorsa fkorsa commented Jan 11, 2018

This merge request fixes two issues that were showstoppers for me. Please integrate them, or not, as you see fit. Everything included here is just a suggestion.

If you want me to refine these commits to be more consistent with your style, I'll be happy to. In this case just tell me the issues you see.

… cotire, so that it doesn't have to be the first file passed to add_library or add_executable.
… PCH, so that they benefit from the compilation boost.
Copy link

@jogerh jogerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found during review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants