LineCountBear.py: Add default values

Set default values for min_lines_per_file and max_lines_per_file. Fixes coala#1477
saksham189 · Apr 21, 2018 · 20cdaf4 · 20cdaf4
1 parent c086e4a
commit 20cdaf4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/bears/general/LineCountBear.py b/bears/general/LineCountBear.py
@@ -18,8 +18,8 @@ def _get_blank_line_count(self, file):
             list(filter(lambda x: re.match(r'^\s*$', x), file)))
         return num_blank_lines
 
-    def run(self, filename, file, min_lines_per_file: int,
-            max_lines_per_file: int,
+    def run(self, filename, file, min_lines_per_file: int = 1,
+            max_lines_per_file: int = 1000,
             exclude_blank_lines: bool = False,
             ):
         """

diff --git a/tests/general/LineCountBearTest.py b/tests/general/LineCountBearTest.py
@@ -69,7 +69,6 @@ def test_one_element_range(self):
             filename='default')
 
     def test_default_min_lines_per_file(self):
-        self.section.append(Setting('min_lines_per_file', 1))
         self.section.append(Setting('max_lines_per_file', 2))
         self.section.append(Setting('exclude_blank_lines', True))
         self.check_results(