PrettierLintBear.py: Fix syntax error regex

Fixes coala#2365
saksham189 · Apr 21, 2018 · 8570505 · 8570505
1 parent 2508d61
commit 8570505
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 7 deletions.
diff --git a/bears/js/PrettierLintBear.py b/bears/js/PrettierLintBear.py
@@ -24,13 +24,17 @@ class PrettierLintBear:
     CAN_FIX = {'Formatting'}
     SEE_MORE = 'https://prettier.io/'
 
-    regex = re.compile(r'L(?P<line>\d+)C(?P<column>\d+): (?P<message>.*)')
+    regex = re.compile(
+        r'(?P<message>SyntaxError:.*) '
+        r'\((?P<line>\d+):(?P<column>\d+)\)')
 
     def process_output(self, output, filename, file):
         stdout, stderr = output
-        yield from self.process_output_corrected(stdout, filename, file)
-        yield from self.process_output_regex(stderr, filename, file,
-                                             self.regex)
+        if stdout == '\n':
+            yield from self.process_output_regex(stderr, filename, file,
+                                                 self.regex)
+        else:
+            yield from self.process_output_corrected(stdout, filename, file)
 
     @staticmethod
     def create_arguments(filename, file, config_file):

diff --git a/tests/js/PrettierLintBearTest.py b/tests/js/PrettierLintBearTest.py
@@ -26,7 +26,10 @@
 
 bad_quotes = """const a = () => 'Foo bar';"""
 
-bad_parentheses = """function b(){
+bad_syntax_function = """function b(){
+"""
+
+bad_syntax_if = """if x y
 """
 
 good_parentheses = """function b() {}
@@ -47,5 +50,6 @@
                                                   good_indent,),
                                      invalid_files=(bad_file,
                                                     bad_quotes,
-                                                    bad_parentheses,
-                                                    bad_indent,))
+                                                    bad_indent,
+                                                    bad_syntax_if,
+                                                    bad_syntax_function,))