Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify types #40

Open
saku-koodari opened this issue Sep 4, 2016 · 6 comments
Open

unify types #40

saku-koodari opened this issue Sep 4, 2016 · 6 comments
Labels

Comments

@saku-koodari
Copy link
Owner

saku-koodari commented Sep 4, 2016

type of 8-bit values is byte and
type of 16-bit value is ushort (in CPU) and int in Memory.

Also there is a few methods that we can combine, if every type would be int.

@saku-koodari
Copy link
Owner Author

At the moment is better that everything would be integer. If (host's) memory is the issue, then we must rethink this.

@saku-koodari
Copy link
Owner Author

This should do before we continue with #2

@saku-koodari
Copy link
Owner Author

When I looked GPU and Memory, maybe it would be better to leave their types what they are now.
I put this on hold for while.

@saku-koodari
Copy link
Owner Author

At the moment I think I should replace every ushort with int:
For now design > perfomance. int values is easier to handle, because you don't need to cast them, unlike ushort.

saku-koodari pushed a commit that referenced this issue Sep 6, 2016
@saku-koodari
Copy link
Owner Author

However I am not sure, where I should convert every byte to int. Byte is (should be faster), but also it gives a visual clue, what kind of data they are holding

@saku-koodari
Copy link
Owner Author

saku-koodari commented Sep 6, 2016

This is actually duplicate issue with: #4 data type as ushort or int?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant