Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOS_CREATEPROMPT オプションを指定しないように変更 #1932

Merged
merged 1 commit into from
Aug 23, 2023
Merged

FOS_CREATEPROMPT オプションを指定しないように変更 #1932

merged 1 commit into from
Aug 23, 2023

Conversation

beru
Copy link
Contributor

@beru beru commented Aug 21, 2023

CDlgOpenFile_CommonItemDialog::DoModalOpenDlgImpl1 メソッドで、FOS_CREATEPROMPT オプションを指定しないように変更しました。

PR対象

  • アプリ(サクラエディタ本体)

カテゴリ

  • 不具合修正

PR の背景

#1930

仕様・動作説明

PR の影響範囲

テスト内容

関連 issue, PR

#1930

参考資料

@beru
CDlgOpenFile_CommonItemDialog::DoModalOpenDlgImpl1 メソッドで FOS_CREATEPR…
235a44d 
…OMPT オプションを指定しないように変更
@beru beru added the 🐛bug🦋 ■バグ修正(Something isn't working) label Aug 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@AppVeyorBot
Copy link

✅ Build sakura 1.0.4307 completed (commit 41a62db7d8 by @beru)

@beru
Copy link
Contributor Author

beru commented Aug 23, 2023

レビューありがとうございます。Mergeします。
もし問題が見つかったら別のPRで修正します。

@beru beru merged commit 63bb10a into sakura-editor:master Aug 23, 2023
20 of 24 checks passed
@beru beru deleted the CommonFileDialog_MessageBox branch August 23, 2023 05:25
@beru beru mentioned this pull request Sep 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
🐛bug🦋 ■バグ修正(Something isn't working)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beru @AppVeyorBot @berryzplus