Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a classname of pylint for testcases #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

themanifold
Copy link

Quick fix for #8

@rasjani
Copy link

rasjani commented Oct 27, 2020

pickup up the pr into my own fork and released in 0.3.0

@themanifold
Copy link
Author

@rasjani Is yours the "official" fork? Is it on pypi?

@rasjani
Copy link

rasjani commented Oct 27, 2020

@themanifold i did ask @vade5g to move the project to my account but that hasnt happened.. All the code and project was done by me while i was working in Siili/SALabs and since nobody has picked this up, i just cloned the project to my private account ..

0.3.0 was upload to PyPi: https://pypi.org/project/pylint-junit/0.3.0/

@themanifold
Copy link
Author

@rasjani I think there's an issue that pops up for me now that you've merged my changes, but I can't figure out why:

pylint --verbose --load-plugins pylint_junit --output-format junit log_handler.py 
Using config file /home/app/.pylintrc
b'<?xml version="1.0" ?>\n<testsuites disabled="0" errors="0" failures="0" tests="0" time="0.0">\n\t<testsuite disabled="0" errors="0" failures="0" name="log_handler" skipped="0" tests="0" time="0"/>\n</testsuites>\n'

The output seems to be a direct output of a byte encoded string.

If you use the older version, then you get what I expect:

pylint --verbose --load-plugins pylint_junit --output-format junit log_handler.py 
Using config file /home/app/.pylintrc
<?xml version="1.0" ?>
<testsuites disabled="0" errors="0" failures="0" tests="0" time="0.0">
        <testsuite disabled="0" errors="0" failures="0" name="log_handler" skipped="0" tests="0" time="0"/>
</testsuites>

@rasjani
Copy link

rasjani commented Oct 27, 2020

Which Python version you are using ?

@themanifold
Copy link
Author

@rasjani I've tried this with 3.7 and 3.8

@themanifold
Copy link
Author

You'll note that classname=pylint does not appear in the XML.

@rasjani
Copy link

rasjani commented Oct 27, 2020

Pushed 0.3.1 to pypi. Should fix that.

@themanifold
Copy link
Author

That's funny. I have my own implementation of that too that I just put in this MR @rasjani

@rasjani
Copy link

rasjani commented Oct 27, 2020

classname should now be present in 0.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants