Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken: Update PluginDocumentSettingPanel to load from new location #32

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

salcode
Copy link
Owner

@salcode salcode commented Jul 26, 2024

This PR works for WordPress 6.6 but is not backwards
compatible with older versions of WordPress core (e.g. WordPress 6.5)

See #31

@salcode
Copy link
Owner Author

salcode commented Jul 26, 2024

If I'm following correctly, this fails in older versions of WordPress because of the dependencies.

$asset_file['dependencies'],

Before Updating @wordpress/scripts

["wp-components","wp-compose","wp-data","wp-edit-post","wp-element","wp-i18n","wp-plugins"]

After Updating @wordpress/scripts

["react-jsx-runtime","wp-components","wp-compose","wp-data","wp-editor","wp-element","wp-i18n","wp-plugins"]

react-jsx-runtime and wp-editor are new dependencies, while wp-edit-post has been removed

salcode added 2 commits July 26, 2024 16:18
Update @wordpress/scripts from 22.5.0 to
the latest, 28.4.0

This was accomplished by running
npm install @wordpress/[email protected] --force

See #31
Change source for PluginDocumentSettingPanel from
@wordpress/edit-post
to
@wordpress/editor

To address the change introduced in WordPress 6.6

Resolves #31
@salcode salcode force-pushed the chore/plugin-settings-panel-package-move-31 branch from 35042a6 to dede025 Compare July 26, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant