Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action for validation branch name during deployment workflow #807

Merged
merged 1 commit into from
Oct 30, 2023
Merged

GitHub Action for validation branch name during deployment workflow #807

merged 1 commit into from
Oct 30, 2023

Conversation

yurii-glia
Copy link
Contributor

@yurii-glia yurii-glia commented Oct 18, 2023 •
edited
Loading

What was solved?
A new GitHub Action validates the branch name from where it has been run and fails if the branch name is not 'master' or 'release/'.

Contains 2 commits:

  • GitHub Action source in ts. Be aware that js files are generated by es2016 3d48b77
  • Contains node_modules required for running Action ee047a6

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Tests updated? Added? Unit, acceptance, snapshots?
  • Logging for future troubleshooting of client issues added?

Screenshots:

@yurii-glia yurii-glia force-pushed the github-actions/0 branch 22 times, most recently from d68e6e3 to ee047a6 Compare October 23, 2023 09:40
@yurii-glia yurii-glia changed the title test GitHub Action for validation branch name during deployment workflow Oct 23, 2023
@yurii-glia yurii-glia marked this pull request as ready for review October 23, 2023 09:43
Pelkar
Pelkar approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@Pelkar Pelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First link looks to be nice, second link I don't really know what is relevant. Trusting Yurii :)

andrews-moc
andrews-moc reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@andrews-moc andrews-moc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Let me just clarify regarding node_modules. Usually this folder is added to .gitignore.
Should node_modules for actions be really be added to repository?

@yurii-glia yurii-glia force-pushed the github-actions/0 branch 8 times, most recently from 3a455f1 to ac5c840 Compare October 27, 2023 10:44
@yurii-glia
Create GitHub Action for validation deployment
f4434e3 
A new GitHub Action validates branch name from
where it has been run and fails if the branch name
is not 'master' or 'release/'.
@yurii-glia yurii-glia merged commit 8948aff into development Oct 30, 2023
7 checks passed
@yurii-glia yurii-glia deleted the github-actions/0 branch October 30, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pelkar Pelkar Pelkar approved these changes

@gugalo gugalo gugalo approved these changes

@DavDo DavDo DavDo approved these changes

@andrews-moc andrews-moc andrews-moc approved these changes

@AndriiHorishniiMOC AndriiHorishniiMOC AndriiHorishniiMOC approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yurii-glia @Pelkar @gugalo @DavDo @andrews-moc @AndriiHorishniiMOC