Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show snackbar when engagement request is timed out #1043

Conversation

rasmustautsglia
Copy link
Contributor

What was solved?
Snackbar needs to be showed after request has timed out. Also, if outcome is anythign but nil or timed_out, we need to ignore it

MOB-3499

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:

@rasmustautsglia
Copy link
Contributor Author

!squash

Snackbar needs to be showed after request has timed out. Also, if outcome is anythign but nil or timed_out, we need to ignore it
@sm-deployer sm-deployer force-pushed the Show-snackbar-when-engagement-request-is-timed-out branch from c5c12c6 to 835dce6 Compare September 13, 2024 08:06
@rasmustautsglia rasmustautsglia merged commit 844e988 into development Sep 13, 2024
8 checks passed
@rasmustautsglia rasmustautsglia deleted the Show-snackbar-when-engagement-request-is-timed-out branch September 13, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants