Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Sample integration project with 2.8.0 SDK version #1049

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Update Sample integration project with 2.8.0 SDK version #1049

merged 1 commit into from
Sep 23, 2024
+152 −84

Conversation

ykyivskyi-gl
Copy link
Contributor

MOB-3598

What was solved?
Update Glia Sample Integration project with 2.8.0 SDK version to show usage example of Call Visualizer, Secure Conversation and Authentication.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Screenshots:

Screenshot 2024-09-20 at 17 24 55 Screenshot 2024-09-20 at 17 24 55

igorkravchenko
igorkravchenko reviewed Sep 23, 2024
View reviewed changes
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions.

Example/Glia Sample Integration/Presenters/ContentViewPresenter.swift Outdated Show resolved Hide resolved
Example/Glia Sample Integration/Presenters/ContentViewPresenter.swift Show resolved Hide resolved
@ykyivskyi-gl ykyivskyi-gl force-pushed the feature/MOB-3598-update-integration-sample-with-2.8.0 branch from a103b7a to 22e97af Compare September 23, 2024 11:39
@sm-deployer sm-deployer force-pushed the feature/MOB-3598-update-integration-sample-with-2.8.0 branch from 22e97af to bf50db7 Compare September 23, 2024 11:39
@ykyivskyi-gl
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the feature/MOB-3598-update-integration-sample-with-2.8.0 branch from bf50db7 to 2e34b16 Compare September 23, 2024 11:40
@ykyivskyi-gl ykyivskyi-gl merged commit 4fab8ca into master Sep 23, 2024
8 checks passed
@ykyivskyi-gl ykyivskyi-gl deleted the feature/MOB-3598-update-integration-sample-with-2.8.0 branch September 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@EgorovEI EgorovEI EgorovEI approved these changes

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ykyivskyi-gl @igorkravchenko @EgorovEI @rasmustautsglia