Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EntryWidget embedded view #1053

Conversation

rasmustautsglia
Copy link
Contributor

What was solved?
This PR adds the possibility to embed EntryWidget to a view. Also, as was agreed upon within the team, there is no instance of EntryWidget within Glia. EntryWidget instance will be returned from getEntryWidget method

MOB-3479

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

Screenshots:

Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a visual change, is it possible to attach screenshot of thew view, or it is too early for that?

Also there is a linter warning related to these changes.

@rasmustautsglia
Copy link
Contributor Author

Simulator Screenshot - iPhone 15 Pro Max - 2024-09-27 at 09 45 10

@rasmustautsglia
Copy link
Contributor Author

rasmustautsglia commented Sep 27, 2024

@igorkravchenko Added a screenshot and removed the swiftlint warning in EntryWidget Theme 983e34d

@rasmustautsglia
Copy link
Contributor Author

!squash

This PR adds the possibility to embed EntryWidget to a view. Also, as
was agreed upon within the team, there is no instance of EntryWidget
within Glia. EntryWidget instance will be returned from getEntryWidget
method

MOB-3479
@rasmustautsglia rasmustautsglia merged commit 69175f6 into feature/entry-widget-and-secure-conversations-v2 Sep 29, 2024
8 checks passed
@rasmustautsglia rasmustautsglia deleted the Add-EntryWidget-Embedded-View branch September 29, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants