Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry message sending logic for Secure Conversations #1058

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

EgorovEI
Copy link
Contributor

@EgorovEI EgorovEI commented Oct 2, 2024

MOB-3597

What was solved?
This commit:

  • adds retry logic for Secure Conversations transcript screen;
  • adds units tests

Snapshot test will be added in next PR

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKsThings to consider for newly added logs in Confluence for more information.

This commit:
- adds retry logic for Secure Conversations transcript screen;
- adds units tests

MOB-3597
Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@EgorovEI EgorovEI merged commit 86a51c9 into development Oct 3, 2024
8 checks passed
@EgorovEI EgorovEI deleted the feature/MOB-3597-send-message-retry-logic branch October 3, 2024 12:38
@EgorovEI EgorovEI restored the feature/MOB-3597-send-message-retry-logic branch October 3, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants