Revamp local build and CI #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
take-five
force-pushed
the
add-ci-checks
branch
2 times, most recently
from
782d746
to
f3aae22
Compare
sliiser
approved these changes
Jul 2, 2024
This commit adds some improvements to the local development experience and adds more checks to CI. Namely: - `Makefile` with targets that make local development simpler: `make build`, `make test`, `make audit`, etc. - Same checks are added to CI to ensure code quality for each PR. - [golangci-lint][1] is added to the checks. - Linter warnings are fixed. - Tests are also run before the release. - Go updated to 1.22. [1]: https://github.com/golangci/golangci-lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds some improvements to the local development experience and adds more checks to CI.
Namely:
Makefilewith targets that make local development simpler:make build,make test,make audit, etc.