-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #309 - Add help text #316
base: hotfix
Are you sure you want to change the base?
Conversation
@yunusyerli1 |
<ndc-dynamic | ||
[ndcDynamicComponent]="componentType" | ||
[ndcDynamicInputs]="{ | ||
<div [title]="field.definition.help ?? '' "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yunusyerli1, better to use a <span>
instead of a div. Fields can be used inline and in many places, not only on the standard views
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
2f294c8
to
2cac11f
Compare
2cac11f
to
ab059c0
Compare
Hey @yunusyerli1, @clemente-raposo I wanted to get your opinions on something, for this. While testing this, I'd noticed that the user is not able to see the tooltip on non-edit views, (ie: Detail/List/Modal), if the field has no data. I feel this might be worth investigating, to further enhance this. Thanks! |
Does it display help text when we don't have data in the field? |
Description
In Studio if you populate the 'Help Text' on a field, it's expected that when you hover that field in the Views, you'd see the text you added in Studio. However currently nothing appears to happen. #309
Motivation and Context
After adding help text in studio, and after hovering on related filed, it is expected to see help text as tooltip.
How To Test This
Add help text on a field in Studio and repair and rebuild. Hover on the field on related module on browser.
Types of changes
Final checklist