Fix #323 - Make dropdownenum dynamic #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clemente-raposo
added
Status: Requires Testing
Status: Passed Code Review
Status:Assessed
yunusyerli1
changed the title
|
@johnM2401 this wasn't merged because it had issues if I'm not mistaken. Correct? @yunusyerli1 the issue was that the values was not saved on dependent field was not saved. See attached gif made by @johnM2401
|
clemente-raposo
added
Status:Requires Updates
|
Hey @clemente-raposo ! Yeah, I believe that's right. As you say, the child Dynamic Dropdown wouldn't save any values. |
|
I will check this. |
yunusyerli1
force-pushed
the
fix/323_make_dynamic_dropdowns
branch
from
5ef7edf
to
4c2a9ce
Compare
yunusyerli1
removed
the
Status:Requires Updates
clemente-raposo
approved these changes
Oct 26, 2023
clemente-raposo
added
Status: Passed Code Review
and removed
Status: Requires Code Review
labels
|
Moved to #382 MR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
checkAndInitAsDynamicEnum();method has been added to dropdownenum.component #323Motivation and Context
The status field in the Cases module is showing all values no matter what value is selected in the State field.
How To Test This
In base-field.manifest.ts file change following:
From :
'enum.detail': EnumDetailFieldComponent,
'enum.edit': EnumEditFieldComponent,
To:
'enum.detail': DropdownEnumDetailFieldComponent,
'enum.edit': DropdownEnumEditFieldComponent,
In editview, select State and check Status field. You ll see all values.
Select another value in State, and still you will see all the values
Types of changes
Final checklist