Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/329 submit required #388

Open
wants to merge 2 commits into
base: hotfix
Choose a base branch
from

Conversation

yunusyerli1
Copy link
Contributor

Description

Check Detail View defs to see if any field has it's require for submit (required_f_submit) flag set to 'True', if it does, it will disable the "Submit button" until that field is populated. The User should still be able to use the other buttons like 'Save & Continue' without those fields being populated.

Motivation and Context

If "Submit" button added on a module, this feature will disable the button until related field is populated or validated. In this scenerio, the record view has "Submit", "Save and Continue" and "Cancel" buttons. Instead of "Save" button, we have "Save and Continue" but this doesnt submit the record to database. It actually save the record temporarily and doesnt exist edit view. When all fields are ready to be sent to database, "Submit" button is clicked. But, some fields are necessary to be populated to be able submit the record.

How To Test This

Create a submit button on a module. This button needs to send the data to database after an edit. During editing, without populating required fields (required_f_submit flag in their related detailviewdefs' fields), submit button needs to be kept disabled until all required fields are populated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants