Fix #10541 - Relation M2M between Security Groups and Security Groups raises an error #10542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On class M2MRelationship, the function add has a special if when on side of the relationship is with Security Groups. When a relation between SGs and SGs is created, the execution flow follows this special IF, but that's wrong: normal flow should be followed.
This PR corrects the IF condition.
Motivation and Context
When a M2M relations between SGs and SGs exists, and anyone tries to select a SG from SG subpanel on SG detail view an error occurs.
How To Test This
1.Create a M2M relation between Security Groups and Security Groups
2.Create a new Security group
3.From the "Security Suite Management" subpanel select another existing security group
Types of changes
Final checklist