Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #10541 - Relation M2M between Security Groups and Security Groups raises an error #10542

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Description

On class M2MRelationship, the function add has a special if when on side of the relationship is with Security Groups. When a relation between SGs and SGs is created, the execution flow follows this special IF, but that's wrong: normal flow should be followed.
This PR corrects the IF condition.

Motivation and Context

When a M2M relations between SGs and SGs exists, and anyone tries to select a SG from SG subpanel on SG detail view an error occurs.

How To Test This

1.Create a M2M relation between Security Groups and Security Groups
2.Create a new Security group
3.From the "Security Suite Management" subpanel select another existing security group

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member PR 4-8 Score given to PRs once assessed Branch:Hotfix Area:Relationships Issues & PRs related to all things regarding to Relationships Status: Requires Code Review Needs the core team to code review labels Oct 14, 2024
@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

thanks for your contribution!

Regards,
Serhii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Relationships Issues & PRs related to all things regarding to Relationships Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants