Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 10545 - Current user groups are used instead of "created by" groups when they differ #10546

Open
wants to merge 1 commit into
base: hotfix
Choose a base branch
from

Conversation

SinergiaCRM
Copy link
Contributor

Description

Fixing #10545
When creating a record from an entrypoint and setting the set_created_by to false, security groups from current user were used instead of security groups from the specified user.
A change to SecurityGroups bean has been made to use the created_by user if it is filled instead of using always the current user.

Motivation and Context

If an entry points set a creator user different from the current user, the groups from the specified should be used. Usually generic users used on some entrypoints does not have security groups at all.

How To Test This

Using the same steps specified to reproduce the issue, check that groups from the specified user are used.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@serhiisamko091184 serhiisamko091184 added the Status:Requires Updates Issues & PRs which requires input or update from the author label Oct 14, 2024
@serhiisamko091184
Copy link
Contributor

Hello @SinergiaCRM,

could you, please, update the commit message, linking the issue?

Like in this PR:
image

Many thanks!

Regards,
Serhii

@enricsinergia
Copy link

Hello @SinergiaCRM,

could you, please, update the commit message, linking the issue?

Like in this PR: image

Many thanks!

Regards, Serhii

Done @serhiisamko091184

@serhiisamko091184
Copy link
Contributor

Hey @SinergiaCRM

Thanks a lot!

Regards,
Serhi

@serhiisamko091184 serhiisamko091184 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Branch:Hotfix PR 4-8 Score given to PRs once assessed and removed Status:Requires Updates Issues & PRs which requires input or update from the author labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants