Fix #10570 - Email Signature Compose View Issues

[ojs87]

Description

Email signatures will sometimes remove the email thread when replying to an email.

Email signatures elements that are on an email thread will also be replaced by the users email signature.

Email signatures will occasionally not be added to the email if the From fields have not been fully loaded in.

From fields can fail to load due to php82 fatal errors

PHP Fatal error:  Uncaught TypeError: EmailsDataAddressCollector::getFillDataAddressArray(): Argument #7 ($prependSignature) must be of type bool, null given, called in /var/www/SuiteCRM/modules/Emails/EmailsDataAddressCollector.php on line 673 and defined in /var/www/SuiteCRM/modules/Emails/EmailsDataAddressCollector.php:753

PHP Fatal error:  Uncaught TypeError: in_array(): Argument #2 ($haystack) must be of type array, bool given in /var/www/SuiteCRM/modules/Emails/EmailsDataAddressCollector.php:151

Includes fixes proposed by @JackBuchanan in #9746

Motivation and Context

Email is an integral part of the CRM system and these inconsistencies are causing issues using the Email module for sending emails. This should provide consistency in how emails are loaded on the Compose and reply to views. Additional improvements could be made once this consistency is established.

How To Test This

1. Set up an email signature on the user profile
2. Import an email to reply to
3. Open the email and choose Reply To
4. See that occasionally the email thread will be deleted, the email signature will not be loaded, and previous email signature elements can be replaced by the users current email signature(even if other SuiteCRM users are in the thread)

Alternative for non-thread related issues

1. Set up an email signature on the user profile
2. Navigate to the compose view on the Emails modules
3. Refresh multiple times, occasionally the email signature will not be added

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

• My code follows the code style of this project found here.
• My change requires a change to the documentation.
• I have read the How to Contribute guidelines.

[serhiisamko091184]

Hey @ojs87,

thanks for your PR!

Regards,
Serhii