Continue request

[ghost]

I enabled the ability to pass more options to get/retrieve requests instead of just filters.
If the options are passed directly to SoapClient.retrieve it will correctly pass filters as well as continueRequest which was previously not possible.

Additionally I added some comments and removed unused code in DataExtension and DataExtensionColumn.

[DougMidgley]

@manivinesh @sfdrogojan can you potentially look at this?

[manivinesh]

@manivinesh @sfdrogojan can you potentially look at this?

We will take a look at it.

[ghost]

Continue Request is needed for SOAP calls if more than 2500 entries are to be retrieved as per this documentation: https://developer.salesforce.com/docs/atlas.en-us.noversion.mc-apis.meta/mc-apis/continuerequest_2500records.htm

[DougMidgley]

@manivinesh any progress here?

[ghost]

@RobertZimmermann, @DougMidgley PR is being reviewed

[manivinesh]

Looks like @sfcbetiuc tried to run the tests with the new changes and noticed 17 tests are failing which were not failing in the master branch.

Issue:
Before the PR, the tests were asserting based on the length of object and it was expecting it to be 1 always, now that the new changes make the filters to actually work, the length is now coming as more than 1 and it cause those tests to fail.

To fix this issue:

Pull in the latest code from the master branch and
Fix the length issue in the failing tests.

@sfcbetiuc @DougMidgley @RobertZimmermann