Skip to content

Commit

Permalink
fix(accordion): remove max-width prop (#5332)
Browse files Browse the repository at this point in the history
* fix(accordion): remove max-width prop

* chore: remove on focus and add focus visible

* chore: update fix for overflow

* chore: update popover-brand variant button focus
  • Loading branch information
Amarnath510 authored Apr 29, 2024
1 parent 13ff5f6 commit 7207364
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion ui/components/accordion/base/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@
padding-bottom: var(--slds-c-accordion-section-spacing-block-end, var(--sds-c-accordion-section-spacing-block-end, #{$spacing-small}));
padding-left: var(--slds-c-accordion-section-spacing-inline-start, var(--sds-c-accordion-section-spacing-inline-start, #{$spacing-small}));
background-color: var(--slds-c-accordion-summary-color-background, var(--sds-c-accordion-summary-color-background, transparent));

// For Action Overflow Menu variant
.slds-dropdown-trigger .slds-button {
margin-left: $spacing-small;
}
}

/**
Expand Down Expand Up @@ -112,7 +117,6 @@
&:hover,
&:focus {
color: var(--sds-c-accordion-heading-text-color-hover, var(--sds-c-accordion-heading-text-color-hover, $brand-accessible-active));
max-width: max-content;
}
}

Expand Down
4 changes: 2 additions & 2 deletions ui/components/popovers/brand/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
}
}

// Historically Close button is not visible hence removed the focus
&:not(.slds-popover_brand-dark) {
// Historically close button is not visible for Brand variant
&:not(.slds-popover_brand-dark):not(.slds-popover_prompt) {
.slds-button:focus {
box-shadow: none;
}
Expand Down

0 comments on commit 7207364

Please sign in to comment.