Skip to content

Commit

Permalink
fix(modal): update property to accept pure rgba to ensure proper rend…
Browse files Browse the repository at this point in the history
…ering of backdrop (#2907)

fix(button): disable point events on children elements of button
  • Loading branch information
brandonferrua authored Nov 8, 2017
1 parent b3b4b83 commit 728a0a9
Show file tree
Hide file tree
Showing 4 changed files with 28 additions and 2 deletions.
22 changes: 22 additions & 0 deletions design-tokens/color-palettes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,3 +43,25 @@ aliases:
PALETTE_GRAY_10: "{!PALETTE_WARM_GRAY_10}"
PALETTE_GRAY_11: "{!PALETTE_WARM_GRAY_11}"
PALETTE_GRAY_12: "{!PALETTE_WARM_GRAY_12}"

## TRANSPARENT GRAYS BASED ON DARKEST GRAY (PALETTE_GRAY_12)
PALETTE_DARK_GRAY_TRANSPARENT_10: "rgba(43, 40, 38, 0.1)"
PALETTE_DARK_GRAY_TRANSPARENT_20: "rgba(43, 40, 38, 0.2)"
PALETTE_DARK_GRAY_TRANSPARENT_30: "rgba(43, 40, 38, 0.3)"
PALETTE_DARK_GRAY_TRANSPARENT_40: "rgba(43, 40, 38, 0.4)"
PALETTE_DARK_GRAY_TRANSPARENT_50: "rgba(43, 40, 38, 0.5)"
PALETTE_DARK_GRAY_TRANSPARENT_60: "rgba(43, 40, 38, 0.6)"
PALETTE_DARK_GRAY_TRANSPARENT_70: "rgba(43, 40, 38, 0.7)"
PALETTE_DARK_GRAY_TRANSPARENT_80: "rgba(43, 40, 38, 0.8)"
PALETTE_DARK_GRAY_TRANSPARENT_90: "rgba(43, 40, 38, 0.9)"

## TRANSPARENT GRAYS BASED ON LIGHTEST GRAY (PALETTE_GRAY_1)
PALETTE_LIGHT_GRAY_TRANSPARENT_10: "rgba(255, 255, 255, 0.1)"
PALETTE_LIGHT_GRAY_TRANSPARENT_20: "rgba(255, 255, 255, 0.2)"
PALETTE_LIGHT_GRAY_TRANSPARENT_30: "rgba(255, 255, 255, 0.3)"
PALETTE_LIGHT_GRAY_TRANSPARENT_40: "rgba(255, 255, 255, 0.4)"
PALETTE_LIGHT_GRAY_TRANSPARENT_50: "rgba(255, 255, 255, 0.5)"
PALETTE_LIGHT_GRAY_TRANSPARENT_60: "rgba(255, 255, 255, 0.6)"
PALETTE_LIGHT_GRAY_TRANSPARENT_70: "rgba(255, 255, 255, 0.7)"
PALETTE_LIGHT_GRAY_TRANSPARENT_80: "rgba(255, 255, 255, 0.8)"
PALETTE_LIGHT_GRAY_TRANSPARENT_90: "rgba(255, 255, 255, 0.9)"
2 changes: 1 addition & 1 deletion design-tokens/force-base-skin/background-color.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ props:
value: '{!PALETTE_GRAY_8}'
comment: 'Used as the default background color for temporary dialog elements, such as the progress spinner background.'
COLOR_BACKGROUND_TEMP_MODAL_TINT:
value: '{!PALETTE_GRAY_8}'
value: '{!PALETTE_DARK_GRAY_TRANSPARENT_60}'
comment: The color of the mask overlay that appears when you enter a modal state.
COLOR_BACKGROUND_TEMP_MODAL_TINT_ALT:
value: '{!WHITE_TRANSPARENT_75}'
Expand Down
4 changes: 4 additions & 0 deletions ui/components/buttons/base/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,10 @@

&[disabled] {
color: $color-text-button-default-disabled;

* {
pointer-events: none;
}
}

&:hover,
Expand Down
2 changes: 1 addition & 1 deletion ui/components/modals/base/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@
right: 0;
bottom: 0;
left: 0;
background: rgba($color-background-temp-modal-tint, 0.8);
background: $color-background-temp-modal-tint;
z-index: $z-index-modal;

/**
Expand Down

0 comments on commit 728a0a9

Please sign in to comment.