Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Switch to [email protected] #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch to [email protected] #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
.generated
.idea
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what your standards are, but I thought it'd be fine to add an IDE specific (IntelliJ in this instance) folder to .gitignore.

.www
node_modules
npm-debug.log
yarn-error.log
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ Example project for integrating Design Tokens using [theo](https://github.com/sa
```bash
$ git clone https://github.com/salesforce-ux/theo-example.git
$ cd theo-example
$ npm install
$ yarn install
```

## Development

While developing your website or Design Tokens use `npm run dev`
While developing your website or Design Tokens use `yarn dev`
and then open [localhost:3000](http://localhost:3000).

Now you can start editing your `src/index.html` and `src/styles/main.scss`.
Expand Down
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,9 @@
"scripts": {
"dev": "gulp dev",
"prestart": "gulp"
},
"engines": {
"node": ">=8.9.1",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was not an engine information for the node version, so I set it to the version that we use. I can replace it whatever version that this project normally assumes.

"yarn": ">=1.3.2"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the yarn version I generated the lock file with. Though, the latest yarn version is 1.6.0.

}
}
Loading