Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: release v8.9.0 #4893

Merged
merged 23 commits into from
Nov 19, 2024
Merged

chore: release v8.9.0 #4893

merged 23 commits into from
Nov 19, 2024

Conversation

nolanlawson
Copy link
Collaborator

Details

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

wjhsf and others added 23 commits November 13, 2024 08:37
@wjhsf
chore(forks): auto trigger nucleus tests (#4850)
2d11a5b 
Script to run CI for forks doesn't include triggering nucleus tests; now it does!
@jmsjtu @wjhsf
feat: remove decorator imports visitor (#4840)
f233039 
* feat: remove decorator imports visitor

* Update packages/@lwc/ssr-compiler/src/compile-js/remove-decorator-import.ts

Co-authored-by: Will Harney <[email protected]>

---------

Co-authored-by: Will Harney <[email protected]>
@ekashida
chore: remove deprecated contextmenu html global attribute (#4834)
29a641e
@cardoso
chore(ssr): attribute-global-html/as-component-prop/with-@api no lo…
bfc799b 
…nger fails (#4854)
@cardoso @nolanlawson
fix(engine-core): log warnings instead of errors on hydration mismatch (
2c6875c 
#4848)

Co-authored-by: Nolan Lawson <[email protected]>
@wjhsf @nolanlawson
test(ssr-compiler): narrow which unused imports are expected (#4856)
24fb303 
Co-authored-by: Nolan Lawson <[email protected]>
@cardoso
chore(ssr): use test options for expected failures (#4844)
2efbadf
@cardoso
chore(deps): remove eslint-plugin-jest (#4846)
86cc503 
* chore(deps): remove eslint-plugin-jest

* chore: clean up eslint config

* chore: add more lint rules to tests
@wjhsf @nolanlawson
fix(engine-server): reflect global HTML attributes @W-17146845 (#4855)
574ffbd 
* test(hydration): global html attributes are borked

* chore(test): don't expect SSR-specific output

* wip

* fix(engine-server): reflect global HTML attributes

* chore: clarify tree-shakeable error

* refactor: use reflection twice

otherwise @lwc/shared isn't tree-shakeable

* refactor: organize reflection files

* chore: cleanup

* test(reflection): update test to reflect reflected global attributes

* fix(spellcheck): use correct boolean logic

---------

Co-authored-by: Nolan Lawson <[email protected]>
@nolanlawson
fix(ssr): fix rendering of spellcheck attribute (#4868)
7d7dea4
@jmsjtu
feat: add dynamic components for @lwc/ssr-compiler (#4847)
b777da2
@nolanlawson
test(ssr): test global html literals on components (#4864)
09f0355
@nolanlawson
fix(ssr): remove unused imports (#4873)
b47e18c
@nolanlawson @nrobertdehault
fix(hydration): ignore host scope token in class validation (#4865)
d2be62a 
Co-authored-by: Nicolas Robert Dehault <[email protected]>
@nolanlawson @jmsjtu
test(ssr): add more tests for dynamic components (#4872)
d30539f 
Co-authored-by: James Tu <[email protected]>
@nolanlawson
fix(ssr): make sync mode default, fix it (#4869)
cdbf06c
@dependabot
build(deps): bump @eslint/plugin-kit from 0.2.0 to 0.2.3 (#4877)
711266e 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @nolanlawson
build(deps): bump the theoretically-non-breaking group with 16 updates (
88bf8a7 
#4881)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nolan Lawson <[email protected]>
@nolanlawson @wjhsf
test(ssr): add test for dynamic imports (#4878)
cd36585 
Co-authored-by: Will Harney <[email protected]>
@wjhsf
feat(ssr): avoid adding unused imports @W-17263761 (#4883)
666e8fe 
* refactor: move import helper to context

* fix(imports): remove import when @track is used

* fix(imports): only import connectContext when necessary

* chore: rename functions for clarity

* fix(imports): only import htmlEscape when necessary

* refactor(imports): use more helper

* chore: remove unused dependency removal

don't need to remove them if we never add them

* refactor: fix up importer
@ekashida
chore(ssr): dynamic imports as noops (#4887)
3f0e444
@wjhsf
chore: remove unnecessary block statements (#4888)
e677e5c
@nolanlawson
chore: release v8.9.0 (#4890)
de3e691
@nolanlawson nolanlawson requested a review from a team as a code owner November 19, 2024 17:20
@nolanlawson
Copy link
Collaborator Author

/nucleus release

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

✅ All Pre-release Checks Passed

  • ✅ Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy
  • ✅ Check PR is approved
    PR 4893 is approved
  • ✅ Check PR is mergeable
    PR 4893 is mergeable
  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR
  • ✅ Check no conflicting Github release
  • ✅ Check NPM packages have not been released yet
  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts
  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@salesforce-nucleus Salesforce Nucleus
Copy link
Contributor

🚢 Release Starting

This pull request has been merged and the release of version 8.9.0 is starting.

You can monitor the progress of the release in Nucleus by visiting the following URL.
https://nucleus.uipengsys-public.buildndeliver-s.aws-esvc1-useast2.aws.sfdc.cl/workflows/254475

@nolanlawson nolanlawson merged commit de3e691 into release Nov 19, 2024
21 of 22 checks passed
@nolanlawson nolanlawson deleted the nolan/release-20241119 branch November 19, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhsf wjhsf wjhsf approved these changes

@ekashida ekashida ekashida approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nolanlawson @ekashida @wjhsf @jmsjtu @cardoso